-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check empty SIMD vector in inline asm #135295
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
You can also delete the file |
The generation of this type should simply be rejected, it is not a legal SIMD type. |
...oh, this does that. My brain. |
@Jubilee: Yeah, this is an instance of a common pattern in the compiler where we can't detect the invalidity of another item. We could perhaps just delay a bug rather than issuing another user error at the usage site, but I think this is a good first step. |
This comment has been minimized.
This comment has been minimized.
Thank you for your review I added the requested changes. |
@bors r+ rollup |
Check empty SIMD vector in inline asm fixes [rust-lang#134334](rust-lang#134334)
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135295 (Check empty SIMD vector in inline asm) - rust-lang#135873 (coverage: Prepare for upcoming changes to counter creation) - rust-lang#135926 (Implement `needs-subprocess` directive, and cleanup a bunch of tests to use `needs-{subprocess,threads}`) - rust-lang#135950 (Tidy Python improvements) - rust-lang#135956 (Make `Vec::pop_if` a bit more presentable) - rust-lang#135966 ([AIX] Allow different sized load and store in `tests/assembly/powerpc64-struct-abi.rs`) - rust-lang#135983 (Doc difference between extend and extend_from_slice) r? `@ghost` `@rustbot` modify labels: rollup
@bors r- failed in rollup #135986 (comment) |
This comment was marked as resolved.
This comment was marked as resolved.
@bors r- |
1 similar comment
This comment was marked as off-topic.
This comment was marked as off-topic.
The test was failing on aarch64-apple-darwin.
☔ The latest upstream changes (presumably #137573) made this pull request unmergeable. Please resolve the merge conflicts. |
fixes #134334