Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check empty SIMD vector in inline asm #135295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check empty SIMD vector in inline asm #135295

wants to merge 2 commits into from
+38 −9

Conversation

eyraudh
Copy link

@eyraudh eyraudh commented Jan 9, 2025 •
edited
Loading

fixes #134334

@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 9, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

You can also delete the file tests/crashes/134334.rs.

@workingjubilee
Copy link
Member

The generation of this type should simply be rejected, it is not a legal SIMD type.

@workingjubilee
Copy link
Member

...oh, this does that. My brain.

@compiler-errors
Copy link
Member

@Jubilee: Yeah, this is an instance of a common pattern in the compiler where we can't detect the invalidity of another item. We could perhaps just delay a bug rather than issuing another user error at the usage site, but I think this is a good first step.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@eyraudh
Copy link
Author

eyraudh commented Jan 10, 2025 •
edited
Loading

You can also delete the file tests/crashes/134334.rs.

Thank you for your review I added the requested changes.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 23, 2025

📌 Commit e5b3cb5 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2025
@matthiaskrgr
Rollup merge of rust-lang#135295 - eyraudh:master, r=compiler-errors
7778aca 
Check empty SIMD vector in inline asm

fixes [rust-lang#134334](rust-lang#134334)
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 24, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2025
@bors
Auto merge of rust-lang#135986 - matthiaskrgr:rollup-eszobzi, r=matth…
62a7968 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#135295 (Check empty SIMD vector in inline asm)
 - rust-lang#135873 (coverage: Prepare for upcoming changes to counter creation)
 - rust-lang#135926 (Implement `needs-subprocess` directive, and cleanup a bunch of tests to use `needs-{subprocess,threads}`)
 - rust-lang#135950 (Tidy Python improvements)
 - rust-lang#135956 (Make `Vec::pop_if` a bit more presentable)
 - rust-lang#135966 ([AIX] Allow different sized load and store in `tests/assembly/powerpc64-struct-abi.rs`)
 - rust-lang#135983 (Doc difference between extend and extend_from_slice)

r? `@ghost`
`@rustbot` modify labels: rollup
@jyn514
Copy link
Member

jyn514 commented Jan 24, 2025

@bors r- failed in rollup #135986 (comment)

@bors

This comment was marked as resolved.

Sign in to view
@Noratrieb
Copy link
Member

@bors r-

1 similar comment
@jieyouxu

This comment was marked as off-topic.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 24, 2025
@eyraudh
fix: running the test only on x86_64.
14c0832 
The test was failing on aarch64-apple-darwin.
@bors
Copy link
Contributor

bors commented Feb 25, 2025

☔ The latest upstream changes (presumably #137573) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: intrinsicck: index out of bounds: the len is 0 but the index is 0
10 participants
@eyraudh @rustbot @rust-log-analyzer @compiler-errors @workingjubilee @bors @jyn514 @Noratrieb @jieyouxu @oli-obk