-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #135986
Closed
Closed
Rollup of 7 pull requests #135986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change test to check only. - Don't ignore `wasm` or `sgx`. - Gate test to be Unix only because Unix `CommandExt` influences the suggestion. - Run rustfix on the suggestion.
- Remove already stabilized feature gate and `#![allow(stable_features)]`. - Convert `ignore-windows` to `only-unix`. - Convert `ignore-*` to `needs-subprocess`.
- Convert `ignore-windows` to `only-unix`. - Convert `ignore-*` to `needs-subprocess`.
- Remove already stable feature gate and `#![allow(stable_features)]`. - Replace `ignore-windows` with `only-unix`. - Replace `ignore-*` with `needs-subprocess`.
- Remove redundant `#![allow(stable_features)]`. - Replace `ignore-*` with `needs-subprocess`.
- Replace `ignore-windows` -> `only-unix` since the test exercises Unix signals and `ExitStatus::code` behavior that's specific to Unix. - Replace `ignore-*` with `needs-subprocess`.
- Remove already stable feature gate and remove `#![allow(stable_features)]`. - Replace `ignore-*` with `needs-subprocess`.
- Remove unnecessary `#![allow(unused_imports)]`. - Replace `ignore-*` with `needs-subprocess`.
- Replace `ignore-windows` with `only-unix`. - Replace `ignore-*` with `needs-subprocess`.
- Replace `ignore-windows` with `only-unix`. - Replace `ignore-*` with `needs-subprocess`.
- Remove unnecessary `mut` and remove `#![allow(unused_mut)]`. - Replace `ignore-*` with `needs-process`.
- Remove already stable feature gate and remove `#![allow(stable_features)]`. - Replace `ignore-*` with `needs-subprocess`.
- Unwrap a must-use I/O result and remove `#![allow(unused_must_use)]`. - Replace `ignore-*` with `needs-subprocess`.
- Ignore an unused variable and remove `#![allow(unused_variables)]`. - Replace `ignore-*` with `needs-subprocess`.
- Ignore unused value, remove `#![allow(unused_variable)]`. - Replace `ignore-*` with `needs-subprocess`.
- Remove unnecessary `mut`, remove `#[allow(unused_mut)]`. - Replace `ignore-*` with `needs-subprocess`.
- Ignore unused value, remove `#![allow(unused_variable)]`. - Replace `ignore-*` with `needs-subprocess`.
….rs` - Ignore unused value, remove `#![allow(unused_variable)]`. - Replace `ignore-*` with `needs-subprocess`.
- Use `only-unix` instead of `ignore-windows`. - Replace `ignore-*` with `needs-subprocess`.
- Use `needs-threads` instead of `ignore-sgx`. - Remove unnecessary import and `#![allow(unused_import)]`.
- Convert `run-pass` to `check-pass`, the test is about closure inference based on expected type, does not need to run-pass. - Dropped unnecessary ignores.
These types are unlikely to ever contain type information in the foreseeable future, so excluding them from TypeFoldable/TypeVisitable avoids some unhelpful derive boilerplate.
…=onur-ozkan Tidy Python improvements Fixes display of Python formatting diffs in tidy, and refactors the code to make it simpler and more robust. Also documents Python formatting and linting in the Rustc dev guide. Fixes: rust-lang#135942 r? `@onur-ozkan`
Make `Vec::pop_if` a bit more presentable rust-lang#135488 minus stabilization. As suggested in rust-lang#135488 (comment). r? tgross35
…ngjubilee [AIX] Allow different sized load and store in `tests/assembly/powerpc64-struct-abi.rs` Sometimes in the llvm backend generates 2 different copy assembly sequence. 1. `lxvd2x` followed immediately by `stxvd2x` (Load VSX Vector 2 Dword, Store VSX Vector 2 Dword) is semantically equivalent to; 2. `lxvw4x` followed immediately by `stxvw4x` (Load VSX Vector 4 Word, Store VSX Vector 4 Word)
Doc difference between extend and extend_from_slice fixes rust-lang#97119
@bors r+ rollup=never p=7 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135295 (Check empty SIMD vector in inline asm) - rust-lang#135873 (coverage: Prepare for upcoming changes to counter creation) - rust-lang#135926 (Implement `needs-subprocess` directive, and cleanup a bunch of tests to use `needs-{subprocess,threads}`) - rust-lang#135950 (Tidy Python improvements) - rust-lang#135956 (Make `Vec::pop_if` a bit more presentable) - rust-lang#135966 ([AIX] Allow different sized load and store in `tests/assembly/powerpc64-struct-abi.rs`) - rust-lang#135983 (Doc difference between extend and extend_from_slice) r? `@ghost` `@rustbot` modify labels: rollup
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors r- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-compiletest
Area: The compiletest test runner
A-rustc-dev-guide
Area: rustc-dev-guide
A-testsuite
Area: The testsuite used to check the correctness of rustc
A-tidy
Area: The tidy tool
rollup
A PR which is a rollup
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
needs-subprocess
directive, and cleanup a bunch of tests to useneeds-{subprocess,threads}
#135926 (Implementneeds-subprocess
directive, and cleanup a bunch of tests to useneeds-{subprocess,threads}
)Vec::pop_if
a bit more presentable #135956 (MakeVec::pop_if
a bit more presentable)tests/assembly/powerpc64-struct-abi.rs
#135966 ([AIX] Allow different sized load and store intests/assembly/powerpc64-struct-abi.rs
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup