Clippy subtree update #146218

flip1995 · 2025-09-04T22:28:23Z

The first statement of the block might have been in a different context from the expression. Walk up to the right context to get bounds properly. Also, switch to `snippet_with_applicability()` since we know that we are in the right context already.

`option_map_unwrap_or` and `seek_rewind` are not current lints, and cannot be referenced as having the `msrv` configuration option.

Before this change, the suggestion for `Option.or(Some(vec![])).unwrap()` expanded the `vec!` macro which broke the code, both in terms of readability, and because the expansion references `$crate` which cannot be inlined.

use trait item's HirId when emitting lint at `check_item` level changelog: [`missing_inline_in_public_items`]: fix trait item lint emission Signed-off-by: Zihan <zihanli0822@gmail.com>

…ubtree-update

avoids bounds checks

`None` is the fallback case anyway

to be able to reuse `did`

`trait_name` can only be _one_ of those at the same time

…ang#15540) changelog: [`ptr_cast_constness`]: avoid suggesting unresolvable method call Spell check says "unresolvable" isn't a word. Which repository do I open a PR against to fix that? Fixes rust-lang/rust-clippy#11317

…rors add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.

@ghost

Forgot to do this at the start of the week. Will be back on the 15th. (That's also the reason why I forgot about the meeting. Sorry for that!) r? @ghost changelog: none

@ghost

r? @ghost changelog: integer-to-pointer-transmutes are now handled by the upstream `integer_to_ptr_transmutes` Rust lint and no longer by the [`useless_transmute`] Clippy lint

…ubtree-update

rustbot · 2025-09-04T22:28:30Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rustbot · 2025-09-04T22:28:32Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- 228f064
- b43e625
- 12a4f4d
- ae97d31
- 7997f33
- 8a8caeb
- 4bb6a0e
- df0499a
- 3a3d3e4
- 55286e7
- 5ce5b89
- b7d76e2
- 7d43319
- 36ef395
- 85622ca
- 7dd11b8
- 9e1c9eb
- 0744c88
- 35fb26f
- 65bac18
- ae571c8
- e24bd58
- f35c203
- 64d5553
- f6c7786
- 7b611d4
- 5f80080
- b6343a5
- ad419b8
- 9373413
- 75d01b7
- 22c47f0
- 0126bc9
- 1dee616
- b3d0a09
- f0514d9
- 798f754
- c4acbce
- c394c00
- 9bfa95b
- d727fa2
- cc0df52
- 9121dcc
- 0afd6a6
- f982b48
- c0f29d7
- 44abf28
- 1a7127c
- 2badfe8
- 7fd0b9e
- 034136d
- 3f74c96
- c98ce18
- 1b21661
- 7250a1a
- d97640c
- 059cf0e
- 5ac9657
- b3c3efe
- e9b7045

flip1995 · 2025-09-04T22:44:23Z

The job was not acquired by Runner of type hosted even after multiple attempts
Internal server error. Correlation ID: bbd75497-6a39-4b01-a5e1-9acaa3e75ea9

🤔 Closing and reopening to restart PR CI

Manishearth · 2025-09-04T22:46:18Z

@bors r+ p=1 rollup=never

bors · 2025-09-04T22:46:20Z

📌 Commit 75b9ee5 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2025-09-05T02:01:54Z

⌛ Testing commit 75b9ee5 with merge 91edc3e...

bors · 2025-09-05T05:16:30Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 91edc3e to master...

github-actions · 2025-09-05T05:19:30Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b3cfb8f (parent) -> 91edc3e (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 91edc3ebccc4daa46c20a93f4709862376da1fdd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 5813.9s -> 8966.0s (54.2%)
aarch64-apple: 6463.1s -> 4853.3s (-24.9%)
pr-check-1: 1368.3s -> 1705.4s (24.6%)
x86_64-gnu-llvm-19-1: 3314.4s -> 3621.9s (9.3%)
armhf-gnu: 4670.7s -> 5095.2s (9.1%)
x86_64-msvc-ext3: 6203.8s -> 6694.4s (7.9%)
x86_64-gnu-miri: 4814.9s -> 4434.2s (-7.9%)
x86_64-gnu-llvm-20-1: 3586.2s -> 3309.6s (-7.7%)
x86_64-gnu-tools: 3792.3s -> 3521.1s (-7.2%)
dist-i686-msvc: 8019.0s -> 7457.2s (-7.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-05T06:26:10Z

Finished benchmarking commit (91edc3e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-4.6%, -2.6%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.7%, secondary 3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	3.7%	[3.7%, 3.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.377s -> 468.177s (0.17%)
Artifact size: 390.50 MiB -> 390.48 MiB (-0.00%)

y21 and others added 30 commits June 21, 2025 15:02

rework useless_vec lint

a8d417d

Add test case for array false positive

bfd73cc

Make sure spans are from the root

47e8c31

Remove references to two unknown lints in config

a7162e4

`option_map_unwrap_or` and `seek_rewind` are not current lints, and cannot be referenced as having the `msrv` configuration option.

Check that all configuration options reference existing lints

07b04a2

or_then_unwrap suggestion preserves macro calls

0170d6c

Before this change, the suggestion for `Option.or(Some(vec![])).unwrap()` expanded the `vec!` macro which broke the code, both in terms of readability, and because the expansion references `$crate` which cannot be inlined.

missing_inline_in_public_items: fix lint emission source HirId

4140545

use trait item's HirId when emitting lint at `check_item` level changelog: [`missing_inline_in_public_items`]: fix trait item lint emission Signed-off-by: Zihan <zihanli0822@gmail.com>

ptr_as_ptr: use correct span context for pointer::cast sugg

443860d

fix: redundant_closure suggests wrongly with deref overload

220249e

fix: semicolon_inside_block FP when attribute over expr is not enabled

f11d512

Merge commit '877967959ae8da9814df4f2614971f4d784bf53f' into clippy-s…

71b79ab

…ubtree-update

get_diagnostic_name in other places

02bc3c9

higher: use get_diagnostic_name

abb8960

misc: destruct args directly

e683346

avoids bounds checks

misc: pull condition into guard

34f96a2

`None` is the fallback case anyway

misc: return earlier on name = None

e243f89

non_octal_unix_permissions: get_diagnostic_name once

d32796d

misc: reorder to have struct first, then its method

f0daf23

redundant_clone: partially inline is_type_diagnostic_item

ff831ed

to be able to reuse `did`

len_zero: use get_diagnostic_name

40e67ab

misc: pull another condition into match arm

ff5f095

non_canonical_impls: save diagnostic name to a variable

0a8a7f9

misc: don't bother checking the other case

29f19a9

`trait_name` can only be _one_ of those at the same time

entry: use get_diagnostic_item

1be146f

misc: rewrite as if let

b987e01

misc: match in multiple steps

804c9ac

other uses of get_diagnostic_name

5abee43

is_default_equivalent_ctor: check for String once

f51b5af

is_default_equivalent_ctor: store name in a var

81b4de6

Alexendoo and others added 8 commits September 2, 2025 14:08

Set flip1995 to on-vacation

06e4ed6

Set flip1995 to on-vacation (rust-lang#15614)

b3c3efe

Forgot to do this at the start of the week. Will be back on the 15th. (That's also the reason why I forgot about the meeting. Sorry for that!) r? @ghost changelog: none

Merge remote-tracking branch 'upstream/master' into rustup

4b73b96

Bump nightly version -> 2025-09-04

e9810e5

Rustup (rust-lang#15616)

e9b7045

r? @ghost changelog: integer-to-pointer-transmutes are now handled by the upstream `integer_to_ptr_transmutes` Rust lint and no longer by the [`useless_transmute`] Clippy lint

Merge commit 'e9b70454e4c9584be3b22ddabd26b741aeb06c10' into clippy-s…

75b9ee5

…ubtree-update

rustbot assigned Manishearth Sep 4, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. labels Sep 4, 2025

flip1995 closed this Sep 4, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2025

flip1995 reopened this Sep 4, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 5, 2025

bors merged commit 91edc3e into rust-lang:master Sep 5, 2025
13 of 14 checks passed

rustbot added this to the 1.91.0 milestone Sep 5, 2025

flip1995 deleted the clippy-subtree-update branch September 6, 2025 10:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clippy subtree update #146218

Clippy subtree update #146218

Uh oh!

flip1995 commented Sep 4, 2025

Uh oh!

rustbot commented Sep 4, 2025

Uh oh!

rustbot commented Sep 4, 2025

Uh oh!

flip1995 commented Sep 4, 2025

Uh oh!

Manishearth commented Sep 4, 2025

Uh oh!

bors commented Sep 4, 2025

Uh oh!

bors commented Sep 5, 2025

Uh oh!

bors commented Sep 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

rust-timer commented Sep 5, 2025

Uh oh!

Uh oh!

Clippy subtree update #146218

Clippy subtree update #146218

Uh oh!

Conversation

flip1995 commented Sep 4, 2025

Uh oh!

rustbot commented Sep 4, 2025

Uh oh!

rustbot commented Sep 4, 2025

Uh oh!

flip1995 commented Sep 4, 2025

Uh oh!

Manishearth commented Sep 4, 2025

Uh oh!

bors commented Sep 4, 2025

Uh oh!

bors commented Sep 5, 2025

Uh oh!

bors commented Sep 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Sep 5, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!