Do two passes of handle_opaque_type_uses_next
#147249
Merged
+118
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lcnr
reviewed
Oct 2, 2025
tests/ui/traits/next-solver/opaques/hidden-types-equate-before-fallback.rs
Show resolved
Hide resolved
…pre-fallback where we equate hidden types but do not report errors
rust-cloud-vms
bot
force-pushed
the
opaque-type-fallback
branch
from
ca75834 to
a3fbae5
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
lcnr
reviewed
Oct 3, 2025
|
@lcnr I fixed your first three comments. The rename from |
This comment has been minimized.
This comment has been minimized.
…ve the assert in favor over a comment, and change to & for &mut
jackh726
force-pushed
the
opaque-type-fallback
branch
from
c113b29 to
283ad66
Compare
lcnr
reviewed
Oct 7, 2025
lcnr
reviewed
Oct 7, 2025
Comment on lines
+115
to
+117
| // We do actually need to check this the second pass (we can't just | ||
| // store this), because we can go from `UnconstrainedHiddenType` to | ||
| // `HasDefiningUse` (because of fallback) |
There was a problem hiding this comment.
we can also just go from no uses to a defining use due to fallback, e.g. if you have soem ?will_fallback: Trait<opaque> goal
There was a problem hiding this comment.
That is UnconstrainedHiddleType?
There was a problem hiding this comment.
it could also be None. Maybe not with this specific example, but certainly with ?will_fallback: RequiresSend<fn_ptr_to_opaque>
lcnr
reviewed
Oct 7, 2025
There was a problem hiding this comment.
please also/instead add the more minimized tests from rust-lang/trait-system-refactor-initiative#240
Done. Just put each minimization in the same test file. |
lcnr
reviewed
Oct 13, 2025
lcnr
reviewed
Oct 13, 2025
tests/ui/traits/next-solver/opaques/hidden-types-equate-before-fallback.rs
Outdated
Show resolved
Hide resolved
…inimizations. Update comment and test.
rust-cloud-vms
bot
force-pushed
the
opaque-type-fallback
branch
from
2fc6f80 to
d51f09e
Compare
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 14, 2025
Do two passes of `handle_opaque_type_uses_next` Fixes rust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 14, 2025
Do two passes of `handle_opaque_type_uses_next` Fixes rust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr
bors
added a commit
that referenced
this pull request
Oct 14, 2025
Rollup of 11 pull requests Successful merges: - #146277 (Enable `u64` limbs in `core::num::bignum`) - #146976 (constify basic Clone impls) - #147249 (Do two passes of `handle_opaque_type_uses_next`) - #147266 (fix 2 search graph bugs) - #147468 (Implement fs api set_times and set_times_nofollow) - #147497 (`proc_macro` cleanups (3/N)) - #147594 (std: implement `pal::os::exit` for VEXos) - #147596 (Adjust the Arm targets in CI to reflect latest changes) - #147607 (GVN: Invalidate derefs at loop headers) - #147620 (Avoid redundant UB check in RangeFrom slice indexing) - #147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 14, 2025
Do two passes of `handle_opaque_type_uses_next` Fixes rust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 14, 2025
Do two passes of `handle_opaque_type_uses_next` Fixes rust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 14, 2025
Do two passes of `handle_opaque_type_uses_next` Fixes rust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 14, 2025
Do two passes of `handle_opaque_type_uses_next` Fixes rust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr
This was referenced Oct 14, 2025
bors
added a commit
that referenced
this pull request
Oct 14, 2025
Rollup of 12 pull requests Successful merges: - #146277 (Enable `u64` limbs in `core::num::bignum`) - #146976 (constify basic Clone impls) - #147249 (Do two passes of `handle_opaque_type_uses_next`) - #147266 (fix 2 search graph bugs) - #147497 (`proc_macro` cleanups (3/N)) - #147546 (Suppress unused_parens for labeled break) - #147548 (Fix ICE for never pattern as closure parameters) - #147594 (std: implement `pal::os::exit` for VEXos) - #147596 (Adjust the Arm targets in CI to reflect latest changes) - #147607 (GVN: Invalidate derefs at loop headers) - #147620 (Avoid redundant UB check in RangeFrom slice indexing) - #147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 14, 2025
Rollup merge of #147249 - jackh726:opaque-type-fallback, r=lcnr Do two passes of `handle_opaque_type_uses_next` Fixes rust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr
|
Bors hasn't noticed that this was merged. @bors r- |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/trait-system-refactor-initiative#240
Also did a little bit of cleanup, can squash the commits if decided.
r? lcnr