Skip to content

proc_macro cleanups (3/N) #147497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2025
Merged

proc_macro cleanups (3/N) #147497

merged 3 commits into from
Oct 14, 2025
+33 −38

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Oct 8, 2025 •
edited by rustbot
Loading

Followup to #147386, which removed the old Decode trait.
Can be reviewed commit by commit.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

petrochenkov
petrochenkov reviewed Oct 9, 2025
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2025
@cyrgani cyrgani force-pushed the proc-macro-cleanups-3 branch from f6b6986 to f4219cf Compare October 9, 2025 20:07
@cyrgani cyrgani added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 9, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Oct 10, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 10, 2025

📌 Commit f4219cf has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2025
bjorn3
bjorn3 reviewed Oct 10, 2025
View reviewed changes
@bjorn3
Copy link
Member

bjorn3 commented Oct 10, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2025
@cyrgani cyrgani force-pushed the proc-macro-cleanups-3 branch from f4219cf to 6a12470 Compare October 10, 2025 20:19
@cyrgani cyrgani added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 10, 2025
@cyrgani cyrgani mentioned this pull request Oct 12, 2025
Draft
@bjorn3
Copy link
Member

bjorn3 commented Oct 13, 2025

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Oct 13, 2025

📌 Commit 6a12470 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2025
chenyukang added a commit to chenyukang/rust that referenced this pull request Oct 14, 2025
@chenyukang
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
8c04cf0 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
@chenyukang chenyukang mentioned this pull request Oct 14, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
9bab601 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 14, 2025
@Zalathar
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
ebbb223 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
@Zalathar Zalathar mentioned this pull request Oct 14, 2025
Closed
bors added a commit that referenced this pull request Oct 14, 2025
@bors
Auto merge of #147659 - Zalathar:rollup-1rdmknm, r=Zalathar
26a1e5f 
Rollup of 11 pull requests

Successful merges:

 - #146277 (Enable `u64` limbs in `core::num::bignum`)
 - #146976 (constify basic Clone impls)
 - #147249 (Do two passes of `handle_opaque_type_uses_next`)
 - #147266 (fix 2 search graph bugs)
 - #147468 (Implement fs api set_times and set_times_nofollow)
 - #147497 (`proc_macro` cleanups (3/N))
 - #147594 (std: implement `pal::os::exit` for VEXos)
 - #147596 (Adjust the Arm targets in CI to reflect latest changes)
 - #147607 (GVN: Invalidate derefs at loop headers)
 - #147620 (Avoid redundant UB check in RangeFrom slice indexing)
 - #147647 (Hide vendoring and copyright in GHA group)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
3ee0174 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
df59997 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
@Zalathar Zalathar mentioned this pull request Oct 14, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
0cec036 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
This was referenced Oct 14, 2025
Closed
Closed
bors added a commit that referenced this pull request Oct 14, 2025
@bors
Auto merge of #147662 - Zalathar:rollup-j8ci0f2, r=Zalathar
e100792 
Rollup of 12 pull requests

Successful merges:

 - #146277 (Enable `u64` limbs in `core::num::bignum`)
 - #146976 (constify basic Clone impls)
 - #147249 (Do two passes of `handle_opaque_type_uses_next`)
 - #147266 (fix 2 search graph bugs)
 - #147497 (`proc_macro` cleanups (3/N))
 - #147546 (Suppress unused_parens for labeled break)
 - #147548 (Fix ICE for never pattern as closure parameters)
 - #147594 (std: implement `pal::os::exit` for VEXos)
 - #147596 (Adjust the Arm targets in CI to reflect latest changes)
 - #147607 (GVN: Invalidate derefs at loop headers)
 - #147620 (Avoid redundant UB check in RangeFrom slice indexing)
 - #147647 (Hide vendoring and copyright in GHA group)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 428be2f into rust-lang:master Oct 14, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 14, 2025
rust-timer added a commit that referenced this pull request Oct 14, 2025
@rust-timer
Unrolled build for #147497
b83bae4 
Rollup merge of #147497 - cyrgani:proc-macro-cleanups-3, r=petrochenkov

`proc_macro` cleanups (3/N)

Followup to #147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
@cyrgani cyrgani deleted the proc-macro-cleanups-3 branch October 14, 2025 17:40
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 14, 2025
Closed
@bjorn3
Copy link
Member

bjorn3 commented Oct 14, 2025

Still in the queue

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2025
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@Zalathar
Rollup merge of rust-lang#147497 - cyrgani:proc-macro-cleanups-3, r=p…
1497b43 
…etrochenkov

`proc_macro` cleanups (3/N)

Followup to rust-lang#147386, which removed the old `Decode` trait.
Can be reviewed commit by commit.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge of rust-lang#147662 - Zalathar:rollup-j8ci0f2, r=Zalathar
1cdaf19 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#146277 (Enable `u64` limbs in `core::num::bignum`)
 - rust-lang#146976 (constify basic Clone impls)
 - rust-lang#147249 (Do two passes of `handle_opaque_type_uses_next`)
 - rust-lang#147266 (fix 2 search graph bugs)
 - rust-lang#147497 (`proc_macro` cleanups (3/N))
 - rust-lang#147546 (Suppress unused_parens for labeled break)
 - rust-lang#147548 (Fix ICE for never pattern as closure parameters)
 - rust-lang#147594 (std: implement `pal::os::exit` for VEXos)
 - rust-lang#147596 (Adjust the Arm targets in CI to reflect latest changes)
 - rust-lang#147607 (GVN: Invalidate derefs at loop headers)
 - rust-lang#147620 (Avoid redundant UB check in RangeFrom slice indexing)
 - rust-lang#147647 (Hide vendoring and copyright in GHA group)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cyrgani @rustbot @petrochenkov @bors @bjorn3