Skip to content

Add regression test for 123953 #147269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2025
Merged

Add regression test for 123953 #147269

merged 1 commit into from
Oct 4, 2025

Conversation

@reddevilmidzy
Copy link
Contributor

@reddevilmidzy reddevilmidzy commented Oct 2, 2025 •
edited by rustbot
Loading

close: #123953

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Oct 2, 2025
View reviewed changes
@petrochenkov
Copy link
Contributor

CI is also failing due to a tidy check.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@reddevilmidzy
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 2, 2025
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 3, 2025

📌 Commit fab9906 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 3, 2025
Merged
bors added a commit that referenced this pull request Oct 3, 2025
@bors
Auto merge of #147308 - matthiaskrgr:rollup-ov04tbi, r=matthiaskrgr
f4babc6 
Rollup of 5 pull requests

Successful merges:

 - #147245 (only replace the intended comma in pattern suggestions)
 - #147269 (Add regression test for 123953)
 - #147277 (Extract common logic for iterating over features)
 - #147292 (Respect `-Z` unstable options in `rustdoc --test`)
 - #147300 (Add xtensa arch to object file creation)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147269 - reddevilmidzy:ice-fix, r=petrochenkov
cfb4492 
Add regression test for 123953

close: rust-lang#123953
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147316 - Zalathar:rollup-ehwa64f, r=Zalathar
f29921f 
Rollup of 14 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #144908 (Fix doctest output json)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #147190 (std: `sys::net` cleanups)
 - #147245 (only replace the intended comma in pattern suggestions)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147269 (Add regression test for 123953)
 - #147277 (Extract common logic for iterating over features)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147292 (Respect `-Z` unstable options in `rustdoc --test`)
 - #147300 (Add xtensa arch to object file creation)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147269 - reddevilmidzy:ice-fix, r=petrochenkov
088c176 
Add regression test for 123953

close: rust-lang#123953
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147308 - matthiaskrgr:rollup-ov04tbi, r=matthiaskrgr
a0f398e 
Rollup of 5 pull requests

Successful merges:

 - #147245 (only replace the intended comma in pattern suggestions)
 - #147269 (Add regression test for 123953)
 - #147277 (Extract common logic for iterating over features)
 - #147292 (Respect `-Z` unstable options in `rustdoc --test`)
 - #147300 (Add xtensa arch to object file creation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0d0b695 into rust-lang:master Oct 4, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 4, 2025
rust-timer added a commit that referenced this pull request Oct 4, 2025
@rust-timer
Unrolled build for #147269
e6d43ed 
Rollup merge of #147269 - reddevilmidzy:ice-fix, r=petrochenkov

Add regression test for 123953

close: #123953
@reddevilmidzy reddevilmidzy deleted the ice-fix branch October 4, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

ICE: type variables should not be hashed?

5 participants

@reddevilmidzy @rustbot @rust-log-analyzer @petrochenkov @bors