std: `sys::net` cleanups #147190

joboet · 2025-09-30T15:14:20Z

This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing unsafe). Best reviewed commit-by-commit.

…export

rustbot · 2025-09-30T15:14:26Z

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

joboet · 2025-09-30T15:15:19Z

r? libs
You've been assigned so many of my PRs already...

hkBst · 2025-10-01T12:23:33Z

library/std/src/sys/net/connection/socket/mod.rs

-        let mut len = size_of_val(&storage) as c::socklen_t;
+        let mut storage = MaybeUninit::<c::sockaddr_storage>::uninit();
+        let mut len = size_of::<c::sockaddr_storage>() as c::socklen_t;
        let sock = self.inner.accept(storage.as_mut_ptr() as *mut _, &mut len)?;


perhaps add let storage = storage.assume_init() here?

library/std/src/sys/net/connection/socket/hermit.rs

tgross35 · 2025-10-03T22:16:42Z

@bors r=hkBst,tgross35

bors · 2025-10-03T22:16:46Z

📌 Commit 3534594 has been approved by hkBst,tgross35

It is now in the queue for this repository.

…ross35 std: `sys::net` cleanups This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.

Rollup of 14 pull requests Successful merges: - #142670 (Document fully-qualified syntax in `as`' keyword doc) - #144908 (Fix doctest output json) - #145685 (add CloneFromCell and Cell::get_cloned) - #146330 (Bump unicode_data and printables to version 17.0.0) - #146451 (Fix atan2 inaccuracy in documentation) - #146479 (add mem::conjure_zst) - #147190 (std: `sys::net` cleanups) - #147245 (only replace the intended comma in pattern suggestions) - #147251 (Do not assert that a change in global cache only happens when concurrent) - #147269 (Add regression test for 123953) - #147277 (Extract common logic for iterating over features) - #147280 (Return to needs-llvm-components being info-only) - #147292 (Respect `-Z` unstable options in `rustdoc --test`) - #147300 (Add xtensa arch to object file creation) r? `@ghost` `@rustbot` modify labels: rollup

…ross35 std: `sys::net` cleanups This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.

Rollup of 14 pull requests Successful merges: - #142670 (Document fully-qualified syntax in `as`' keyword doc) - #145685 (add CloneFromCell and Cell::get_cloned) - #146330 (Bump unicode_data and printables to version 17.0.0) - #146451 (Fix atan2 inaccuracy in documentation) - #146479 (add mem::conjure_zst) - #146874 (compiler: Hint at multiple crate versions if trait impl is for wrong ADT ) - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos) - #147190 (std: `sys::net` cleanups) - #147251 (Do not assert that a change in global cache only happens when concurrent) - #147280 (Return to needs-llvm-components being info-only) - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting) - #147309 (Add documentation about unwinding to wasm targets) - #147315 (bless autodiff batching test) - #147323 (Fix top level ui tests check in tidy) r? `@ghost` `@rustbot` modify labels: rollup

…ross35 std: `sys::net` cleanups This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.

Rollup of 11 pull requests Successful merges: - #142670 (Document fully-qualified syntax in `as`' keyword doc) - #145685 (add CloneFromCell and Cell::get_cloned) - #146330 (Bump unicode_data and printables to version 17.0.0) - #146451 (Fix atan2 inaccuracy in documentation) - #146479 (add mem::conjure_zst) - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos) - #147190 (std: `sys::net` cleanups) - #147251 (Do not assert that a change in global cache only happens when concurrent) - #147280 (Return to needs-llvm-components being info-only) - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting) - #147315 (bless autodiff batching test) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - #142670 (Document fully-qualified syntax in `as`' keyword doc) - #145685 (add CloneFromCell and Cell::get_cloned) - #146330 (Bump unicode_data and printables to version 17.0.0) - #146451 (Fix atan2 inaccuracy in documentation) - #146479 (add mem::conjure_zst) - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos) - #147190 (std: `sys::net` cleanups) - #147251 (Do not assert that a change in global cache only happens when concurrent) - #147280 (Return to needs-llvm-components being info-only) - #147315 (bless autodiff batching test) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147190 - joboet:sys-net-cleanup, r=hkBst,tgross35 std: `sys::net` cleanups This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.

joboet added 4 commits September 30, 2025 11:59

std: call WinSock cleanup function directly instead of through its re…

d615d2f

…export

std: improve internal socket functions

eba1416

std: add missing unsafe blocks

aa1263e

std: merge address family computation

3534594

rustbot assigned ibraheemdev Sep 30, 2025

rustbot added O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 30, 2025

rustbot assigned tgross35 and unassigned ibraheemdev Sep 30, 2025

hkBst reviewed Oct 1, 2025

View reviewed changes

library/std/src/sys/net/connection/socket/hermit.rs Show resolved Hide resolved

hkBst approved these changes Oct 1, 2025

View reviewed changes

tgross35 approved these changes Oct 3, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025

Zalathar mentioned this pull request Oct 4, 2025

Rollup of 14 pull requests #147316

Closed

Zalathar mentioned this pull request Oct 4, 2025

Rollup of 13 pull requests #147318

Closed

Zalathar mentioned this pull request Oct 4, 2025

Rollup of 13 pull requests #147324

Closed

Zalathar mentioned this pull request Oct 4, 2025

Rollup of 14 pull requests #147326

Closed

matthiaskrgr mentioned this pull request Oct 4, 2025

Rollup of 11 pull requests #147330

Closed

matthiaskrgr mentioned this pull request Oct 4, 2025

Rollup of 10 pull requests #147340

Merged

bors merged commit c389e2e into rust-lang:master Oct 4, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Oct 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

std: `sys::net` cleanups #147190

std: `sys::net` cleanups #147190

joboet commented Sep 30, 2025

Uh oh!

rustbot commented Sep 30, 2025

Uh oh!

joboet commented Sep 30, 2025

Uh oh!

hkBst Oct 1, 2025

Uh oh!

Uh oh!

tgross35 commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

Uh oh!

Uh oh!

std: sys::net cleanups #147190

std: sys::net cleanups #147190

Conversation

joboet commented Sep 30, 2025

Uh oh!

rustbot commented Sep 30, 2025

Uh oh!

joboet commented Sep 30, 2025

Uh oh!

hkBst Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tgross35 commented Oct 3, 2025

Uh oh!

bors commented Oct 3, 2025

Uh oh!

Uh oh!

Uh oh!

std: `sys::net` cleanups #147190

std: `sys::net` cleanups #147190