Skip to content

Conversation

chenyukang
Copy link
Member

I got an error when pushing code:

fmt check
fmt: checked 6330 modified files
tidy check
tidy [ui_tests (tests)]: ui tests should be added under meaningful subdirectories: `/Users/yukang/rust/tests/ui/.DS_Store`
tidy [ui_tests (tests)]: FAIL

I think it's better to use ignore::WalkBuilder for checking the path.

r? @jieyouxu

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Oct 4, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 4, 2025

📌 Commit 422b914 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Oct 4, 2025

@bors p=1 (or include in rollup)

Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
…r=jieyouxu

Fix top level ui tests check in tidy

I got an error when pushing code:

```console
fmt check
fmt: checked 6330 modified files
tidy check
tidy [ui_tests (tests)]: ui tests should be added under meaningful subdirectories: `/Users/yukang/rust/tests/ui/.DS_Store`
tidy [ui_tests (tests)]: FAIL
```

I think it's better to use `ignore::WalkBuilder` for checking the path.

r? `@jieyouxu`
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
…r=jieyouxu

Fix top level ui tests check in tidy

I got an error when pushing code:

```console
fmt check
fmt: checked 6330 modified files
tidy check
tidy [ui_tests (tests)]: ui tests should be added under meaningful subdirectories: `/Users/yukang/rust/tests/ui/.DS_Store`
tidy [ui_tests (tests)]: FAIL
```

I think it's better to use `ignore::WalkBuilder` for checking the path.

r? ``@jieyouxu``
bors added a commit that referenced this pull request Oct 4, 2025
Rollup of 14 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #146874 (compiler: Hint at multiple crate versions if trait impl is for wrong ADT )
 - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos)
 - #147190 (std: `sys::net` cleanups)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting)
 - #147309 (Add documentation about unwinding to wasm targets)
 - #147315 (bless autodiff batching test)
 - #147323 (Fix top level ui tests check in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Oct 4, 2025

⌛ Testing commit 422b914 with merge 99b9a88...

@bors
Copy link
Collaborator

bors commented Oct 4, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 99b9a88 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 4, 2025
@bors bors merged commit 99b9a88 into rust-lang:master Oct 4, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 4, 2025
Copy link
Contributor

github-actions bot commented Oct 4, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a0f398e (parent) -> 99b9a88 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 99b9a8850349e56247acb6ce19910c7f96db8439 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1662.4s -> 1395.0s (-16.1%)
  2. i686-gnu-2: 6233.1s -> 5371.8s (-13.8%)
  3. x86_64-rust-for-linux: 3038.0s -> 2643.9s (-13.0%)
  4. x86_64-gnu-llvm-20: 2730.8s -> 2409.2s (-11.8%)
  5. aarch64-apple: 8395.5s -> 7442.6s (-11.3%)
  6. dist-aarch64-msvc: 6166.5s -> 5489.1s (-11.0%)
  7. dist-apple-various: 3490.6s -> 3160.7s (-9.5%)
  8. dist-x86_64-apple: 7916.6s -> 7189.6s (-9.2%)
  9. armhf-gnu: 5198.8s -> 4765.5s (-8.3%)
  10. x86_64-gnu-distcheck: 7240.0s -> 6644.0s (-8.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (99b9a88): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.925s -> 470.695s (-0.47%)
Artifact size: 388.34 MiB -> 388.35 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants