Skip to content

Return to needs-llvm-components being info-only #147280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2025
Merged

Return to needs-llvm-components being info-only #147280

merged 1 commit into from
Oct 4, 2025

Conversation

@workingjubilee
Copy link
Member

Partially revert a535042

Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes //@ needs-llvm-components, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.

r? @Kobzol

Related PR: #146618

@workingjubilee
Return to needs-llvm-components being info-only
99550fb 
Partially revert a535042

Even with non-LLVM codegen backends, we want to allow for annotations
that express dependencies to LLVM-specific parts of the test suite.
This includes `//@ needs-llvm-components`, which just allows checking
that LLVM is built with relevant target support before the test is run.
It does not assert the test cannot work with another codegen backend.
@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 2, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Oct 3, 2025

I didn't notice this change. Yes, needs-llvm-components should only be used to condition on which LLVM component the toolchain is built with, it should not be dual-purposed for controlling which codegen backend is used.

@Kobzol
Copy link
Member

Kobzol commented Oct 3, 2025

Ah, this is a bit subtle, sorry for missing that. Yeah, that makes sense. I wonder if we'll eventually need needs-gcc-components or something like that. Actually, some of our test suite will be probably quite "fun" to run with GCC, given that it's (AFAIK) not a cross-compiler, and you need a specific libgccjit library for each target tuple that you build for.

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 3, 2025

📌 Commit 99550fb has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147280 - workingjubilee:you-can-put-your-gc…
da9b223 
…c-in-my-llvm-components, r=Kobzol

Return to needs-llvm-components being info-only

Partially revert a535042

Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes `//@ needs-llvm-components`, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147316 - Zalathar:rollup-ehwa64f, r=Zalathar
f29921f 
Rollup of 14 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #144908 (Fix doctest output json)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #147190 (std: `sys::net` cleanups)
 - #147245 (only replace the intended comma in pattern suggestions)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147269 (Add regression test for 123953)
 - #147277 (Extract common logic for iterating over features)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147292 (Respect `-Z` unstable options in `rustdoc --test`)
 - #147300 (Add xtensa arch to object file creation)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu
Copy link
Member

jieyouxu commented Oct 4, 2025

needs-gcc-components

That would be fine, we just should not use needs-llvm-components for that.

Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147280 - workingjubilee:you-can-put-your-gc…
1706a32 
…c-in-my-llvm-components, r=Kobzol

Return to needs-llvm-components being info-only

Partially revert a535042

Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes `//@ needs-llvm-components`, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147280 - workingjubilee:you-can-put-your-gc…
22e8161 
…c-in-my-llvm-components, r=Kobzol

Return to needs-llvm-components being info-only

Partially revert a535042

Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes `//@ needs-llvm-components`, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147280 - workingjubilee:you-can-put-your-gc…
cb57183 
…c-in-my-llvm-components, r=Kobzol

Return to needs-llvm-components being info-only

Partially revert a535042

Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes `//@ needs-llvm-components`, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147280 - workingjubilee:you-can-put-your-gc…
4e9cab8 
…c-in-my-llvm-components, r=Kobzol

Return to needs-llvm-components being info-only

Partially revert a535042

Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes `//@ needs-llvm-components`, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147326 - Zalathar:rollup-w696bpq, r=Zalathar
8572e48 
Rollup of 14 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #146874 (compiler: Hint at multiple crate versions if trait impl is for wrong ADT )
 - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos)
 - #147190 (std: `sys::net` cleanups)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting)
 - #147309 (Add documentation about unwinding to wasm targets)
 - #147315 (bless autodiff batching test)
 - #147323 (Fix top level ui tests check in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 4, 2025
@matthiaskrgr
Rollup merge of rust-lang#147280 - workingjubilee:you-can-put-your-gc…
7564260 
…c-in-my-llvm-components, r=Kobzol

Return to needs-llvm-components being info-only

Partially revert a535042

Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes `//@ needs-llvm-components`, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 4, 2025
Closed
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147330 - matthiaskrgr:rollup-h4jyzmv, r=matthiaskrgr
1bd98ac 
Rollup of 11 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos)
 - #147190 (std: `sys::net` cleanups)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting)
 - #147315 (bless autodiff batching test)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 4, 2025
Merged
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147340 - matthiaskrgr:rollup-icymmsc, r=matthiaskrgr
2cb4e7d 
Rollup of 10 pull requests

Successful merges:

 - #142670 (Document fully-qualified syntax in `as`' keyword doc)
 - #145685 (add CloneFromCell and Cell::get_cloned)
 - #146330 (Bump unicode_data and printables to version 17.0.0)
 - #146451 (Fix atan2 inaccuracy in documentation)
 - #146479 (add mem::conjure_zst)
 - #147117 (interpret `#[used]` as `#[used(compiler)]` on illumos)
 - #147190 (std: `sys::net` cleanups)
 - #147251 (Do not assert that a change in global cache only happens when concurrent)
 - #147280 (Return to needs-llvm-components being info-only)
 - #147315 (bless autodiff batching test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6c24eee into rust-lang:master Oct 4, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 4, 2025
rust-timer added a commit that referenced this pull request Oct 4, 2025
@rust-timer
Unrolled build for #147280
602238d 
Rollup merge of #147280 - workingjubilee:you-can-put-your-gcc-in-my-llvm-components, r=Kobzol

Return to needs-llvm-components being info-only

Partially revert a535042

Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes `//@ needs-llvm-components`, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.
@workingjubilee workingjubilee deleted the you-can-put-your-gcc-in-my-llvm-components branch October 5, 2025 19:16
@workingjubilee
Copy link
Member Author

workingjubilee commented Oct 5, 2025 •
edited
Loading

@Kobzol It's understandable, it's easy to overlook.

re: needs-gcc-components, I think compiletest itself should just have a way of describing the compilation components that a codegen backend might need. In the annotations, individual tests should only need to describe they are a cross-built test for a target, not what components they need. Then the codegen backend check can be done by referencing another data structure, so we aren't de facto embedding that codegen backend's view of the universe in the tests.

This would moot both needs-llvm-components and needs-gcc-components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kobzol Kobzol

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@workingjubilee @rustbot @jieyouxu @Kobzol @bors