Rollup of 10 pull requests #147340

matthiaskrgr · 2025-10-04T15:11:14Z

Successful merges:

Document fully-qualified syntax in as' keyword doc #142670 (Document fully-qualified syntax in as' keyword doc)
add CloneFromCell and Cell::get_cloned #145685 (add CloneFromCell and Cell::get_cloned)
Bump unicode_data and printables to version 17.0.0 #146330 (Bump unicode_data and printables to version 17.0.0)
Fix atan2 inaccuracy in documentation #146451 (Fix atan2 inaccuracy in documentation)
add mem::conjure_zst #146479 (add mem::conjure_zst)
interpret #[used] as #[used(compiler)] on illumos #147117 (interpret #[used] as #[used(compiler)] on illumos)
std: sys::net cleanups #147190 (std: sys::net cleanups)
Do not assert that a change in global cache only happens when concurrent #147251 (Do not assert that a change in global cache only happens when concurrent)
Return to needs-llvm-components being info-only #147280 (Return to needs-llvm-components being info-only)
bless autodiff batching test #147315 (bless autodiff batching test)

r? @ghost
@rustbot modify labels: rollup

…export

Partially revert a535042 Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes `//@ needs-llvm-components`, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.

illumos' `ld` does not support a flag like either SHF_GNU_RETAIN or SHF_SUNW_NODISCARD, so there is no way to communicate `#[used(linker)]` for that target. Setting `USED_LINKER` to try results in LLVM setting SHF_SUNW_NODISCARD for Solaris-like targets, which is an unknown section header flag for illumos `ld` and prevents sections from being merged that otherwise would. As a motivating example, the `inventory` crate produces `#[used]` items to merge into `.init_array`. Because those items have an unknown section header flag they are not merged with the default `.init_array` with `frame_dummy`, and end up never executed. Downgrading `#[used]` to `#[used(compiler)]` on illumos keeps so-attributed items as preserved as they had been before rust-lang#140872. As was the case before that change, because rustc passes `-z ignore` to illumos `ld`, it's possible that `used` sections are GC'd at link time. rust-lang#146169 describes this unfortunate circumstance.

…-syntax, r=ibraheemdev,fmease Document fully-qualified syntax in `as`' keyword doc

…mmerjake,tgross35 add CloneFromCell and Cell::get_cloned Tracking issue: rust-lang#145329

Bump unicode_data and printables to version 17.0.0 Unicode 17 ~~is not stable yet (release planned for 2025-09-09).~~ [has been released!](https://www.unicode.org/versions/Unicode17.0.0/) Update Unicode data and printables to [Unicode 17](https://www.unicode.org/versions/Unicode17.0.0/)

…ocs, r=tgross35 Fix atan2 inaccuracy in documentation Fixes rust-lang#136275

…cm,tgross35 add mem::conjure_zst Tracking issue: rust-lang#95383

…oratrieb interpret `#[used]` as `#[used(compiler)]` on illumos helps rust-lang#146169 not be as painful: fixes the illumos regression in rust-lang#140872, but `#[used(linker)]` is still erroneous on illumos generally. illumos' `ld` does not support a flag like either SHF_GNU_RETAIN or SHF_SUNW_NODISCARD, so there is no way to communicate `#[used(linker)]` for that target. Setting `USED_LINKER` to try results in LLVM setting SHF_SUNW_NODISCARD for Solaris-like targets, which is an unknown section header flag for illumos `ld` and prevents sections from being merged that otherwise would. As a motivating example, the `inventory` crate produces `#[used]` items to merge into `.init_array`. Because those items have an unknown section header flag they are not merged with the default `.init_array` with `frame_dummy`, and end up never executed. Downgrading `#[used]` to `#[used(compiler)]` on illumos keeps so-attributed items as preserved as they had been before rust-lang#140872. As was the case before that change, because rustc passes `-z ignore` to illumos `ld`, it's possible that `used` sections are GC'd at link time. rust-lang#146169 describes this unfortunate circumstance. ---- as it turns out, `tests/ui/attributes/used_with_archive.rs` had broken on `x86_64-unknown-illumos`, and this patch fixes it. the trials and tribulations of tier 2 :( r? ````@Noratrieb```` probably?

…ross35 std: `sys::net` cleanups This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.

…nt-change, r=lcnr Do not assert that a change in global cache only happens when concurrent Fixes rust-lang/trait-system-refactor-initiative#234 I think it should just be safe to remove this assert (rather than delaying a bug). If the previous and current result are the same, I wouldn't expect issues. r? lcnr

…c-in-my-llvm-components, r=Kobzol Return to needs-llvm-components being info-only Partially revert a535042 Even with non-LLVM codegen backends, we want to allow for annotations that express dependencies to LLVM-specific parts of the test suite. This includes `//@ needs-llvm-components`, which just allows checking that LLVM is built with relevant target support before the test is run. It does not assert the test cannot work with another codegen backend.

…youxu bless autodiff batching test This pr blesses a broken test and unblocks running rust in the Enzyme CI: EnzymeAD/Enzyme#2430 Enzyme is the plugin used by our std::autodiff and (future) std::batching modules, both of which are not build by default. In the near future we also hope to enable std::autodiff in the Rust CI. This test is the only one to combine two features, automatic differentiation and batching/vectorization. This combination is even more experimental than either feature on its own. I have a wip branch in which I enable more vectorization/batching and as part of that I'll think more about how to write those tests in a robust way (and likely change the interface). Until that lands, I don't care too much about what specific IR we generate here; it's just nice to track changes. r? compiler

matthiaskrgr · 2025-10-04T15:11:25Z

@bors r+ rollup=never p=5

bors · 2025-10-04T15:11:27Z

📌 Commit a84359c has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-10-04T18:08:28Z

⌛ Testing commit a84359c with merge 2cb4e7d...

bors · 2025-10-04T21:22:38Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 2cb4e7d to master...

rust-timer · 2025-10-04T21:25:29Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#142670	Document fully-qualified syntax in `as`' keyword doc	`274446ad61eaf8a4ee5d8ee6f171e531acf3f0b4` (link)
#145685	add CloneFromCell and Cell::get_cloned	`24351f733039abfcf45e661bd16de3ae7d3a1fb5` (link)
#146330	Bump unicode_data and printables to version 17.0.0	`89b93186b9991108de1151576db180a5ab1b01fe` (link)
#146451	Fix atan2 inaccuracy in documentation	`0dc71b50cac63556fa004df25227ad4a47c708ca` (link)
#146479	add mem::conjure_zst	`daf9bc2ed1068474333d57dfd04794a03fab3095` (link)
#147117	interpret `#[used]` as `#[used(compiler)]` on illumos	`a2cf263c48d5a7a18dd504bc313aa721bb19b9ab` (link)
#147190	std: `sys::net` cleanups	`65c132b2a8c3bac22954a0c15d5cda8c8cadc629` (link)
#147251	Do not assert that a change in global cache only happens wh…	`9121260f29f9314c7c86269a9f4cc378819d1118` (link)
#147280	Return to needs-llvm-components being info-only	`602238dd9d4a75a55c83528ca79378b3b4c3db0d` (link)
#147315	bless autodiff batching test	`317d48bbed07cd3636c0bbd2e3454189fbb6c0cb` (link)

previous master: 99ca0ae87b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-10-04T21:25:32Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 99ca0ae (parent) -> 2cb4e7d (this PR)

Test differences

Show 1799 test diffs

Stage 1

[ui] tests/ui/consts/std/conjure_zst.rs: [missing] -> pass (J1)
[ui] tests/ui/delegation/unsupported.rs: pass -> [missing] (J1)
[ui] tests/ui/delegation/unsupported.rs#current: [missing] -> pass (J1)
[ui] tests/ui/delegation/unsupported.rs#next: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/consts/std/conjure_zst.rs: [missing] -> pass (J0)
[ui] tests/ui/delegation/unsupported.rs: pass -> [missing] (J0)
[ui] tests/ui/delegation/unsupported.rs#current: [missing] -> pass (J0)
[ui] tests/ui/delegation/unsupported.rs#next: [missing] -> pass (J0)

Additionally, 1791 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2cb4e7dce84fdebc0279159f1082f92b99299d87 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 3298.8s -> 4123.7s (25.0%)
aarch64-apple: 9313.3s -> 7595.3s (-18.4%)
dist-x86_64-apple: 7102.7s -> 7907.5s (11.3%)
aarch64-msvc-1: 7224.9s -> 6475.2s (-10.4%)
aarch64-gnu-debug: 4028.2s -> 3702.5s (-8.1%)
i686-msvc-2: 7723.4s -> 7208.6s (-6.7%)
dist-ohos-armv7: 4631.3s -> 4345.4s (-6.2%)
x86_64-gnu-llvm-20-2: 5612.9s -> 5932.3s (5.7%)
x86_64-gnu-llvm-20-3: 6426.2s -> 6075.5s (-5.5%)
pr-check-1: 1431.6s -> 1356.0s (-5.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-04T22:35:07Z

Finished benchmarking commit (2cb4e7d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	2
Regressions ❌ (secondary)	0.2%	[0.1%, 0.3%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-1.0%, -0.8%]	6
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	2

Max RSS (memory usage)

Results (primary -2.5%, secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-4.2%, -0.8%]	2
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-2.5%	[-4.2%, -0.8%]	2

Cycles

Results (secondary -3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	3

Bootstrap: 471.44s -> 471.593s (0.03%)
Artifact size: 388.29 MiB -> 388.35 MiB (0.01%)

Marcondiro and others added 24 commits September 9, 2025 09:03

Bump unicode_data to version 17.0.0

400e687

Bump unicode printable to version 17.0.0

83a99aa

Fix atan2 inaccuracy in documentation

d834935

std: call WinSock cleanup function directly instead of through its re…

d615d2f

…export

std: improve internal socket functions

eba1416

std: add missing unsafe blocks

aa1263e

std: merge address family computation

3534594

add CloneFromCell and Cell::get_cloned

08b4641

Document fully-qualified syntax in as' keyword doc

1485e78

add mem::conjure_zst

a9ab29c

Do not assert that a change in global cache only happens when concurrent

55aeb17

update autodiff batching test

12cfad9

Rollup merge of rust-lang#142670 - fpdotmonkey:doc/as-fully-qualified…

f837cfe

…-syntax, r=ibraheemdev,fmease Document fully-qualified syntax in `as`' keyword doc

Rollup merge of rust-lang#145685 - Qelxiros:cell_get_cloned, r=progra…

47bd38c

…mmerjake,tgross35 add CloneFromCell and Cell::get_cloned Tracking issue: rust-lang#145329

Rollup merge of rust-lang#146451 - DimitriiTrater:atan2_correctness_d…

baea20b

…ocs, r=tgross35 Fix atan2 inaccuracy in documentation Fixes rust-lang#136275

Rollup merge of rust-lang#146479 - Qelxiros:mem_conjure_zst, r=scottm…

18388b8

…cm,tgross35 add mem::conjure_zst Tracking issue: rust-lang#95383

Rollup merge of rust-lang#147190 - joboet:sys-net-cleanup, r=hkBst,tg…

c389e2e

…ross35 std: `sys::net` cleanups This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing `unsafe`). Best reviewed commit-by-commit.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 4, 2025

bors merged commit 2cb4e7d into rust-lang:master Oct 4, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 4, 2025

This was referenced Oct 4, 2025

Make Rc<T>::deref and Arc<T>::deref zero-cost #132553

Open

Make Rc<T>::deref zero-cost #141348

Open

Remove Cased Unicode table #146180

Open

rustbot added the perf-regression Performance regression. label Oct 4, 2025

bors mentioned this pull request Oct 4, 2025

std::os::windows::net: add Unix-domain socket support (AF_UNIX on Windows) #147335

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #147340

Rollup of 10 pull requests #147340

matthiaskrgr commented Oct 4, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Oct 4, 2025

Uh oh!

bors commented Oct 4, 2025

Uh oh!

bors commented Oct 4, 2025

Uh oh!

bors commented Oct 4, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 4, 2025

Uh oh!

github-actions bot commented Oct 4, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Oct 4, 2025

Uh oh!

Uh oh!

Rollup of 10 pull requests #147340

Rollup of 10 pull requests #147340

Conversation

matthiaskrgr commented Oct 4, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Oct 4, 2025

Uh oh!

bors commented Oct 4, 2025

Uh oh!

bors commented Oct 4, 2025

Uh oh!

bors commented Oct 4, 2025

Uh oh!

Uh oh!

rust-timer commented Oct 4, 2025

Uh oh!

github-actions bot commented Oct 4, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Oct 4, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Oct 4, 2025 •

edited by rustbot

Loading