Skip to content

Conversation

@nicholasbishop
Copy link
Contributor

The UEFI variables set by the env vars should be volatile, otherwise they will persist after reboot and use up scarce non-volatile storage.

CC @Ayush1325

The UEFI variables set by the env vars should be volatile, otherwise
they will persist after reboot and use up scarce non-volatile storage.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@Ayush1325 Ayush1325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Was going through the orignal UEFI env PR and seems it slipped through due to the main topic of discussion being whether to use UEFI shell or not.

View changes since this review

@joboet
Copy link
Member

joboet commented Jan 13, 2026

@bors r+

Yeah, it's too easy to get the flag direction mixed up... thanks for improving the clarity here too.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

📌 Commit c98b90e has been approved by joboet

It is now in the queue for this repository.

@joboet joboet assigned joboet and unassigned Mark-Simulacrum Jan 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
std: Change UEFI env vars to volatile storage

The UEFI variables set by the env vars should be volatile, otherwise they will persist after reboot and use up scarce non-volatile storage.

CC @Ayush1325
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
std: Change UEFI env vars to volatile storage

The UEFI variables set by the env vars should be volatile, otherwise they will persist after reboot and use up scarce non-volatile storage.

CC @Ayush1325
rust-bors bot pushed a commit that referenced this pull request Jan 13, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items)
 - #150677 (Improve std::path::Path::join documentation)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150737 (diagnostics: make implicit Sized bounds explicit in E0277)
 - #150771 (Remove legacy homu `try` and `auto` branch mentions)
 - #150915 (Regression test for type params on eii)
 - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg)
 - #151017 (Port the rustc dump attributes to the attribute parser)
 - #151019 (Make `Type::of` support unsized types)
 - #151034 (std: Change UEFI env vars to volatile storage)
 - #151052 (ui: add regression test for macro resolution ICE (issue #150711))
 - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`)
 - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array)

r? @ghost
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 14, 2026
std: Change UEFI env vars to volatile storage

The UEFI variables set by the env vars should be volatile, otherwise they will persist after reboot and use up scarce non-volatile storage.

CC @Ayush1325
rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #149408 (refactor: remove Ord bound from BinaryHeap::new etc)
 - #150406 (Change some `matches!(.., .. if ..)` with let-chains)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150877 (resolve: Refactor away the side table `decl_parent_modules`)
 - #150902 (Update to_uppercase docs to avoid ß->SS example)
 - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg)
 - #151034 (std: Change UEFI env vars to volatile storage)
 - #151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`)
 - #151067 (Avoid should-fail in two ui tests and a codegen-llvm test)
 - #151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support)
 - #151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake)
 - #151096 (Remove `Deref`/`DerefMut` impl for `Providers`.)

Failed merges:

 - #150939 (resolve: Relax some asserts in glob overwriting and add tests)

r? @ghost
rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
…uwer

Rollup of 11 pull requests

Successful merges:

 - #149408 (refactor: remove Ord bound from BinaryHeap::new etc)
 - #150406 (Change some `matches!(.., .. if ..)` with let-chains)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150877 (resolve: Refactor away the side table `decl_parent_modules`)
 - #150902 (Update to_uppercase docs to avoid ß->SS example)
 - #151034 (std: Change UEFI env vars to volatile storage)
 - #151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`)
 - #151067 (Avoid should-fail in two ui tests and a codegen-llvm test)
 - #151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support)
 - #151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake)
 - #151096 (Remove `Deref`/`DerefMut` impl for `Providers`.)

Failed merges:

 - #150939 (resolve: Relax some asserts in glob overwriting and add tests)

r? @ghost
@rust-bors rust-bors bot merged commit 4874f18 into rust-lang:main Jan 14, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 14, 2026
rust-timer added a commit that referenced this pull request Jan 14, 2026
Rollup merge of #151034 - bishop-fix-nv, r=joboet

std: Change UEFI env vars to volatile storage

The UEFI variables set by the env vars should be volatile, otherwise they will persist after reboot and use up scarce non-volatile storage.

CC @Ayush1325
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 15, 2026
…uwer

Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#149408 (refactor: remove Ord bound from BinaryHeap::new etc)
 - rust-lang/rust#150406 (Change some `matches!(.., .. if ..)` with let-chains)
 - rust-lang/rust#150723 (std: move `errno` and related functions into `sys::io`)
 - rust-lang/rust#150877 (resolve: Refactor away the side table `decl_parent_modules`)
 - rust-lang/rust#150902 (Update to_uppercase docs to avoid ß->SS example)
 - rust-lang/rust#151034 (std: Change UEFI env vars to volatile storage)
 - rust-lang/rust#151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`)
 - rust-lang/rust#151067 (Avoid should-fail in two ui tests and a codegen-llvm test)
 - rust-lang/rust#151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support)
 - rust-lang/rust#151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake)
 - rust-lang/rust#151096 (Remove `Deref`/`DerefMut` impl for `Providers`.)

Failed merges:

 - rust-lang/rust#150939 (resolve: Relax some asserts in glob overwriting and add tests)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants