Reduce flakyness for tests/rustdoc-gui/notable-trait.goml
#151053
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Member
|
@bors r+ rollup |
rust-bors
bot
added
S-waiting-on-bors
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 13, 2026
Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml` Fixes rust-lang#151006 (hopefully). Instead of asserting right away, it waits for the element count to be the one expected. r? @jieyouxu
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 13, 2026
Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml` Fixes rust-lang#151006 (hopefully). Instead of asserting right away, it waits for the element count to be the one expected. r? @jieyouxu
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
…uwer Rollup of 13 pull requests Successful merges: - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items) - #150677 (Improve std::path::Path::join documentation) - #150723 (std: move `errno` and related functions into `sys::io`) - #150737 (diagnostics: make implicit Sized bounds explicit in E0277) - #150771 (Remove legacy homu `try` and `auto` branch mentions) - #150915 (Regression test for type params on eii) - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg) - #151017 (Port the rustc dump attributes to the attribute parser) - #151019 (Make `Type::of` support unsized types) - #151034 (std: Change UEFI env vars to volatile storage) - #151052 (ui: add regression test for macro resolution ICE (issue #150711)) - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`) - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array) r? @ghost
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 13, 2026
Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml` Fixes rust-lang#151006 (hopefully). Instead of asserting right away, it waits for the element count to be the one expected. r? @jieyouxu
This was referenced Jan 13, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
Rollup of 13 pull requests Successful merges: - #150587 (triagebot: add A-rustdoc-js autolabel) - #150677 (Improve std::path::Path::join documentation) - #150737 (diagnostics: make implicit Sized bounds explicit in E0277) - #150771 (Remove legacy homu `try` and `auto` branch mentions) - #150840 (Make `--print=check-cfg` output compatible `--check-cfg` arguments) - #150915 (Regression test for type params on eii) - #151017 (Port the rustc dump attributes to the attribute parser) - #151019 (Make `Type::of` support unsized types) - #151031 (Support arrays in type reflection) - #151043 (armv7-unknown-linux-uclibceabihf.md: Fix bootstrap.toml syntax) - #151052 (ui: add regression test for macro resolution ICE (issue #150711)) - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`) - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 14, 2026
This was referenced Jan 14, 2026
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 15, 2026
Reduce rustdoc GUI flakyness, take 2 Fixes rust-lang#151006 (hopefully). Seems like rust-lang#151053 did not fix the flakyness issue, so here is another take on this issue. r? @jieyouxu
rust-timer
added a commit
that referenced
this pull request
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151006 (hopefully).
Instead of asserting right away, it waits for the element count to be the one expected.
r? @jieyouxu