Skip to content

Conversation

@vsriramv
Copy link
Contributor

@vsriramv vsriramv commented Jan 13, 2026

Added a new test in test/ui/resolve for a macro
resolution scenario that previously caused an ICE.

Files added:

  • tests/ui/resolve/decl-macro-use-no-ice.rs
  • tests/ui/resolve/decl-macro-use-no-ice.stderr

Fixes #150711

r? @matthiaskrgr
r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 13, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2026

matthiaskrgr is currently at their maximum review capacity.
They may take a while to respond.

@rustbot

This comment has been minimized.

@vsriramv vsriramv force-pushed the add-test-ice-in-resolve branch from a50922d to cda6bbc Compare January 13, 2026 08:20
//@ edition: 2024
#![feature(decl_macro)]

// Regression test for issue #150711
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put there a link instead of number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, done!

@vsriramv vsriramv force-pushed the add-test-ice-in-resolve branch from cda6bbc to ef9cbad Compare January 13, 2026 09:03
@Kivooeo
Copy link
Member

Kivooeo commented Jan 13, 2026

@bors r+ rollup

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

📌 Commit ef9cbad has been approved by Kivooeo

It is now in the queue for this repository.

@Kivooeo Kivooeo assigned Kivooeo and unassigned matthiaskrgr Jan 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
ui: add regression test for macro resolution ICE (issue rust-lang#150711)

Added a new test in `test/ui/resolve` for a macro
resolution scenario that previously caused an ICE.

Files added:
- `tests/ui/resolve/decl-macro-use-no-ice.rs`
- `tests/ui/resolve/decl-macro-use-no-ice.stderr`

Fixes rust-lang#150711

r? @matthiaskrgr
r? @petrochenkov
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
ui: add regression test for macro resolution ICE (issue rust-lang#150711)

Added a new test in `test/ui/resolve` for a macro
resolution scenario that previously caused an ICE.

Files added:
- `tests/ui/resolve/decl-macro-use-no-ice.rs`
- `tests/ui/resolve/decl-macro-use-no-ice.stderr`

Fixes rust-lang#150711

r? @matthiaskrgr
r? @petrochenkov
rust-bors bot pushed a commit that referenced this pull request Jan 13, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items)
 - #150677 (Improve std::path::Path::join documentation)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150737 (diagnostics: make implicit Sized bounds explicit in E0277)
 - #150771 (Remove legacy homu `try` and `auto` branch mentions)
 - #150915 (Regression test for type params on eii)
 - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg)
 - #151017 (Port the rustc dump attributes to the attribute parser)
 - #151019 (Make `Type::of` support unsized types)
 - #151034 (std: Change UEFI env vars to volatile storage)
 - #151052 (ui: add regression test for macro resolution ICE (issue #150711))
 - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`)
 - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array)

r? @ghost
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 13, 2026
ui: add regression test for macro resolution ICE (issue rust-lang#150711)

Added a new test in `test/ui/resolve` for a macro
resolution scenario that previously caused an ICE.

Files added:
- `tests/ui/resolve/decl-macro-use-no-ice.rs`
- `tests/ui/resolve/decl-macro-use-no-ice.stderr`

Fixes rust-lang#150711

r? @matthiaskrgr
r? @petrochenkov
rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
Rollup of 13 pull requests

Successful merges:

 - #150587 (triagebot: add A-rustdoc-js autolabel)
 - #150677 (Improve std::path::Path::join documentation)
 - #150737 (diagnostics: make implicit Sized bounds explicit in E0277)
 - #150771 (Remove legacy homu `try` and `auto` branch mentions)
 - #150840 (Make `--print=check-cfg` output compatible `--check-cfg` arguments)
 - #150915 (Regression test for type params on eii)
 - #151017 (Port the rustc dump attributes to the attribute parser)
 - #151019 (Make `Type::of` support unsized types)
 - #151031 (Support arrays in type reflection)
 - #151043 (armv7-unknown-linux-uclibceabihf.md: Fix bootstrap.toml syntax)
 - #151052 (ui: add regression test for macro resolution ICE (issue #150711))
 - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`)
 - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array)

r? @ghost
@rust-bors rust-bors bot merged commit 5b7fc2f into rust-lang:main Jan 14, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 14, 2026
rust-timer added a commit that referenced this pull request Jan 14, 2026
Rollup merge of #151052 - add-test-ice-in-resolve, r=Kivooeo

ui: add regression test for macro resolution ICE (issue #150711)

Added a new test in `test/ui/resolve` for a macro
resolution scenario that previously caused an ICE.

Files added:
- `tests/ui/resolve/decl-macro-use-no-ice.rs`
- `tests/ui/resolve/decl-macro-use-no-ice.stderr`

Fixes #150711

r? @matthiaskrgr
r? @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE in resolve

4 participants