Add support for if let
#17634
Merged
Add support for if let
#17634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks @kballard for the fantastic work on this. I took it over, rebased it and added it to the reference. I'd love to mention it in the guide as well but I feel like @steveklabnik may have a better vision on how to do it well. :) |
|
cc @nick29581 since you reviewed the last one. It's mostly unchanged and passes tests for me locally. |
|
|
|
Edit: IIRC it was always the Mac bots that errored, and I'm seeing this on OS X, so it may be, for some reason, Mac-specific. But I was never able to figure out what the hell was causing it. |
Modify ast::ExprMatch to include a new value of type ast::MatchSource, making it easy to tell whether the match was written literally or produced via desugaring. This allows us to customize error messages appropriately.
It turns out that adding new diagnostics is causing link failures in runpass-full-deps tests. Further investigation pending.
ghost
mentioned this pull request
ghost
deleted the
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 28, 2024
minor: Make xtask install work again CC rust-lang/rust-analyzer#17559 (comment)
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
minor: Make xtask install work again CC rust-lang/rust-analyzer#17559 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #16741.