Add support for while let
#17733
Merged
Add support for while let
#17733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspect that this isn’t supposed to be so heavily based on |
|
Hah, oi. headdesk |
|
Subject line needs fixing. |
| } | ||
| } else { | ||
| span_err!(cx.tcx.sess, pat.span, E0001, "unreachable pattern"); | ||
| span_err!(cx.tcx.sess, span, E0163, "irrefutable while-let pattern"); |
There was a problem hiding this comment.
Is there a specific reason this is an error? What if I want to do an infinite loop with destructuring?
There was a problem hiding this comment.
That's discussed in the RFC: https://github.com/rust-lang/rfcs/blob/master/active/0068-while-let.md#detailed-design
|
Rebased onto current master |
| span_err!(cx.tcx.sess, span, E0165, "irrefutable while-let pattern"); | ||
| }, | ||
|
|
||
| _ => span_err!(cx.tcx.sess, pat.span, E0001, "unreachable pattern") |
There was a problem hiding this comment.
nit: Could you please make this a specific pattern, i.e.:
MatchNormal => span_err!(cx.tcx.sess, pat.span, E0001, "unreachable pattern")The set of variants of this particular enum probably won't grow in the near future but it's still good for clarity, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is heavily based on
if let(#17634) by @jakub- and @kballardThis should close #17687