Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book: let grow() accept the growth parameter #23751

Merged
merged 1 commit into from
Mar 28, 2015
Merged

book: let grow() accept the growth parameter #23751

merged 1 commit into from
Mar 28, 2015

Conversation

tshepang
Copy link
Member

I found the arbitrary 10 surprising. A better method name, in such a case, would be grow_by_10 :)

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member

@bors: r+ rollup

I personally am okay with having overly specific examples like grow_by_10; sometimes having the complexities required to make a method real-world-ish make it unsuitable for docs.

But in this case it seems minor, and also introduces how self methods can take more parameters.

@bors
Copy link
Collaborator

bors commented Mar 28, 2015

📌 Commit 07afd04 has been approved by Manishearth

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 28, 2015
…, r=Manishearth

I found the arbitrary `10` surprising. A better method name, in such a case, would be `grow_by_10` :)
bors added a commit that referenced this pull request Mar 28, 2015
@bors bors merged commit 07afd04 into rust-lang:master Mar 28, 2015
@tshepang tshepang deleted the do-not-hardcode-the-growth branch May 31, 2015 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants