Rollup of 5 pull requests #23806
Merged
Rollup of 5 pull requests #23806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Mar 28, 2015
Manishearth
commented
- Successful merges: Add the -s flag to the suggested rustup invocation #23332, book: let grow() accept the growth parameter #23751, Explain why &self is common #23788, cleanup: Remove unused braces in use statements #23803, book: Fix typo #23804
- Failed merges:
curl's progress meter would otherwise interfere with sudo's password prompt. In addition, add the -f flag to make sure 4xx status codes are treated as errors.
The Send bound is an unnecessary restriction, and though provided as a convenience, can't be removed by downstream code. The removal of this bound is a [breaking-change] since it removes an implicit Send bound on all `E: Error` and all `Error` trait objects. To migrate, consider if your code actually requires the Send bound and, if so, add it explicitly. Fixes rust-lang#23774
The Send bound is an unnecessary restriction, and though provided as a convenience, can't be removed by downstream code. The removal of this bound is a [breaking-change] since it removes an implicit Send bound on all `E: Error` and all `Error` trait objects. To migrate, consider if your code actually requires the Send bound and, if so, add it explicitly. Fixes rust-lang#23774 r? @aturon
…rson curl's progress meter would otherwise interfere with sudo's password prompt. In addition, add the -f flag to make sure 4xx status codes are treated as errors. r? @brson
…, r=Manishearth I found the arbitrary `10` surprising. A better method name, in such a case, would be `grow_by_10` :)
Pretty much what it says on the tin.
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=10 |
|
📌 Commit 95f4061 has been approved by |
|
@bors: force |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.