Skip to content

Fix sidebar bug #23941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2015
Merged

Fix sidebar bug #23941

merged 1 commit into from
Apr 4, 2015

Conversation

carloslfu
Copy link
Contributor

Validate if the description is available in the rawSearchIndex

@carloslfu
Fix sidebar bug
48aea41 
Validate if the description is available in the rawSearchIndex
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

What specifically does this fix?

@carloslfu
Copy link
Contributor Author

When a crate don't have items, an error stops the rendering of sidebar. I found this in the servo generated docs

@steveklabnik
Copy link
Member

Ahhh gotcha, thanks!

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 2, 2015

📌 Commit 48aea41 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 3, 2015
@Manishearth
Rollup merge of rust-lang#23941 - carloslfu:patch-1, r=steveklabnik
cdc5187 
Validate if the description is available in the rawSearchIndex
@Manishearth Manishearth mentioned this pull request Apr 3, 2015
Merged
bors added a commit that referenced this pull request Apr 3, 2015
@bors
Auto merge of #24009 - Manishearth:rollup, r=Manishearth
f77cb26 
- Successful merges: #23930, #23941, #23972, #23976, #23978, #23993, #23995, #23997, #24005
- Failed merges:
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 4, 2015
@Manishearth
Rollup merge of rust-lang#23941 - carloslfu:patch-1, r=steveklabnik
9fc7a1e 
 Validate if the description is available in the rawSearchIndex
@bors bors merged commit 48aea41 into rust-lang:master Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carloslfu @rust-highfive @steveklabnik @bors