Adjust AsRef impl for Cow
#23995
Merged
Adjust AsRef impl for Cow
#23995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing impl had the too-strong requirement of `Clone`, when only `ToOwned` was needed.
|
cc @reem |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 6529872 has been approved by |
reem
added a commit
to reem/hyper
that referenced
this pull request
Apr 3, 2015
We can revert this PR when rust-lang/rust#23995 lands, but it won't land until after beta is cut.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 3, 2015
The existing impl had the too-strong requirement of `Clone`, when only `ToOwned` was needed.
bors
added a commit
that referenced
this pull request
Apr 3, 2015
mikedilger
pushed a commit
to mikedilger/hyper
that referenced
this pull request
Apr 3, 2015
We can revert this PR when rust-lang/rust#23995 lands, but it won't land until after beta is cut.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 4, 2015
The existing impl had the too-strong requirement of `Clone`, when only `ToOwned` was needed.
seanmonstar
pushed a commit
to hyperium/headers
that referenced
this pull request
Jul 9, 2018
We can revert this PR when rust-lang/rust#23995 lands, but it won't land until after beta is cut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing impl had the too-strong requirement of
Clone, when onlyToOwnedwas needed.