Implement PartialEq<str> for String and Cow #23972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -826,6 +826,38 @@ impl_eq! { String, &'a str } | |||
| impl_eq! { Cow<'a, str>, String } | |||
There was a problem hiding this comment.
Btw, you can use &[..] notation inside of impl_eq! like #23521 does and reduce all the impls for Cow<'a, str>, String and str to just a few lines.
|
I've put up a less verbose version of the patch in accordance with @petrochenkov's advice. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 3, 2015
…richton
Right now comparing a `&String` (or a `&Cow`) to a `&str` requires redundant borrowing of the latter. Implementing `PartialEq<str>` tries to avoid this limitation.
```rust
struct Foo (String);
fn main () {
let s = Foo("foo".to_string());
match s {
Foo(ref x) if x == &"foo" => println!("foo!"),
// avoid this -----^
_ => {}
}
}
```
I was hoping that rust-lang#23521 would solve this but it didn't work out.
bors
added a commit
that referenced
this pull request
Apr 3, 2015
bors
added a commit
that referenced
this pull request
Apr 3, 2015
Right now comparing a `&String` (or a `&Cow`) to a `&str` requires redundant borrowing of the latter. Implementing `PartialEq<str>` tries to avoid this limitation.
```rust
struct Foo (String);
fn main () {
let s = Foo("foo".to_string());
match s {
Foo(ref x) if x == &"foo" => println!("foo!"),
// avoid this -----^
_ => {}
}
}
```
I was hoping that #23521 would solve this but it didn't work out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now comparing a
&String(or a&Cow) to a&strrequires redundant borrowing of the latter. ImplementingPartialEq<str>tries to avoid this limitation.I was hoping that #23521 would solve this but it didn't work out.