Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown formatting for error explanations. #25302

Merged
merged 1 commit into from
May 12, 2015
Merged

Markdown formatting for error explanations. #25302

merged 1 commit into from
May 12, 2015

Conversation

michaelsproul
Copy link
Contributor

A few errors slipped through my filter. Markdown formatting is especially important now that http://doc.rust-lang.org/error-index.html is live!

Speaking of, the error index should probably be linked to from somewhere. It doesn't quite fit under any of the sections in the index, but I could create a new one for it? Or add it under "tools" despite it not exactly being an executable tool.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa
Copy link
Member

nagisa commented May 11, 2015

I didn’t catch the previous PR/discussion, but could 4-space identation be used instead as it looks better in CLI IMO?

@pnkfelix
Copy link
Member

@bors r+ ce7ef32

@pnkfelix
Copy link
Member

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 11, 2015
…felix

A few errors slipped through my filter. Markdown formatting is especially important now that http://doc.rust-lang.org/error-index.html is live!

Speaking of, the error index should probably be linked to from somewhere. It doesn't quite fit under any of the sections in the index, but I could create a new one for it? Or add it under "tools" despite it not exactly being an executable tool.
bors added a commit that referenced this pull request May 11, 2015
@michaelsproul
Copy link
Contributor Author

@nagisa: There's some more discussion here: #25033. I think the custom renderer is a good idea, but I can see the appeal of using 4 spaces to indent.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 12, 2015
…felix

A few errors slipped through my filter. Markdown formatting is especially important now that http://doc.rust-lang.org/error-index.html is live!

Speaking of, the error index should probably be linked to from somewhere. It doesn't quite fit under any of the sections in the index, but I could create a new one for it? Or add it under "tools" despite it not exactly being an executable tool.
bors added a commit that referenced this pull request May 12, 2015
@bors bors merged commit ce7ef32 into rust-lang:master May 12, 2015
@michaelsproul michaelsproul deleted the error-markdown branch May 12, 2015 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants