Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra parentheses #25282

Merged
merged 1 commit into from
May 12, 2015
Merged

Remove extra parentheses #25282

merged 1 commit into from
May 12, 2015

Conversation

badboy
Copy link
Member

@badboy badboy commented May 10, 2015

As mentioned in #16676 (comment) this makes it a little bit more correct.

I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@badboy
Copy link
Member Author

badboy commented May 10, 2015

yeah, great. A typo in the commit message -_-

edit: Force-pushed before anyone saw it ;)

@badboy badboy changed the title Remote extra parentheses Remove extra parentheses May 10, 2015
@alexcrichton
Copy link
Member

@bors: r+ f11c4ba rollup

Thanks!

@alexcrichton alexcrichton assigned alexcrichton and unassigned huonw May 11, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 11, 2015
…chton

As mentioned in rust-lang#16676 (comment) this makes it a little bit more correct.

I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.
bors added a commit that referenced this pull request May 11, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 12, 2015
…chton

As mentioned in rust-lang#16676 (comment) this makes it a little bit more correct.

I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.
bors added a commit that referenced this pull request May 12, 2015
@bors bors merged commit f11c4ba into rust-lang:master May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants