Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #25320

Merged
merged 27 commits into from
May 12, 2015
Merged

Rollup of 10 pull requests #25320

merged 27 commits into from
May 12, 2015

Conversation

Ulrik Sverdrup and others added 27 commits May 9, 2015 00:03
This is related to isssue rust-lang#22442 and solves it partly.

This solves the links of associated types and constants, so that they
link to the trait page.
Section only visible if there are assoc. consts. present.
They're only enabled in debug builds, but a panic is usually more
welcome than UB in debug builds.
Change from "must be used with behind a pointer" to "must be used behind a pointer"
Update BitSet docs to correct type in one more spot

removed accidental file
and remove references to the unit type, which no longer exists

Fixes rust-lang#24999
…richton

Rustdoc fixes for associated items

This is related to isssue rust-lang#22442 and solves it partly.

This solves the search index links of associated types and constants,
so that they link to the trait page.

Also add an Associated Constants section if constants are present.
…Gankro

They're only enabled in debug builds, but a panic is usually more
welcome than UB in debug builds.

Previous review at rust-lang#22069

r? @gankro
cc @huon
Adds long diagnostic messages for:

 - E0184
 - E0204
 - E0205
 - E0206
 - E0243
 - E0244
 - E0249
 - E0250

This PR also adds some comments to the error codes in `librustc_typeck/diagnostics.rs`.

cc rust-lang#24407
Change from "must be used with behind a pointer" to "must be used behind a pointer"
…chton

As mentioned in rust-lang#16676 (comment) this makes it a little bit more correct.

I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.
and remove references to the unit type, which no longer exists

Fixes rust-lang#24999
The functions BitSet::{iter,union,symmetric_difference} each had docs that claimed u32s were output when their actual output each end up being usizes.

r? @steveklabnik
…matsakis

I think someday I'd like to make these drawings rather than text, but for now, this will have to be good enough.
…felix

A few errors slipped through my filter. Markdown formatting is especially important now that http://doc.rust-lang.org/error-index.html is live!

Speaking of, the error index should probably be linked to from somewhere. It doesn't quite fit under any of the sections in the index, but I could create a new one for it? Or add it under "tools" despite it not exactly being an executable tool.
@steveklabnik
Copy link
Member Author

@bors: r+ p=1

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented May 12, 2015

📌 Commit 28b923c has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented May 12, 2015

⌛ Testing commit 28b923c with merge a90453a...

bors added a commit that referenced this pull request May 12, 2015
@bors bors merged commit 28b923c into rust-lang:master May 12, 2015
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants