std: small doc fixes for BufReader and BufWriter #26784
Conversation
birkenfeld
commented
Jul 5, 2015
birkenfeld
commented
- fix probable copy-paste error in BufWriter.get_mut()
- more consistent punctuation
* fix probable copy-paste error in BufWriter.get_mut() * more consistent punctuation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -21,7 +21,7 @@ use io::{self, DEFAULT_BUF_SIZE, Error, ErrorKind, SeekFrom}; | |||
| use ptr; | |||
| use iter; | |||
|
|
|||
| /// Wraps a `Read` and buffers input from it | |||
| /// Wraps a `Read` and buffers input from it. | |||
There was a problem hiding this comment.
Convention is to use full sentences, actually, so I'd prefer to leave this (and others)
|
Thanks @birkenfeld ! I'll take the typo fixes, but the periods should stay. |
|
I don't understand - I'm adding the periods, which are also present in the first sentences of other docstrings in this file. |
|
@birkenfeld sorry! I guess I read the diff backwards. Periods are what we want, for sure. |
|
@bors: r+ rollup |
|
📌 Commit df73abe has been approved by |
* fix probable copy-paste error in BufWriter.get_mut() * more consistent punctuation
