Make mention of alternate flags in std::fmt traits #26850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! One of the most awesome parts of this ist that it works for nested structures, too. Do you maybe want to add a more complex example somewhere? (Feel free to copy my test code!) |
|
I don't know, I guess I just assume that it would do so, but maybe assumptions don't matter. |
| @@ -379,6 +410,8 @@ pub trait Display { | |||
| /// | |||
| /// The `Octal` trait should format its output as a number in base-8. | |||
| /// | |||
| /// The alternate flag, `#o`, adds a `0o` in front of the output. | |||
There was a problem hiding this comment.
Hm, isn't just # the alternate flag not the full #o entity? (i.e. one adds the flag to the format specifier o)
There was a problem hiding this comment.
I guess technically that is true.
steveklabnik
force-pushed
the
more_format_docs
branch
from
02eb698 to
6c52903
Compare
|
@huonw updated! |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 8, 2015
bors
added a commit
that referenced
this pull request
Jul 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.reddit.com/r/rust/comments/3ceaui/psa_produces_prettyprinted_debug_output/