Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added how to use labels to break nested loops to trpl. #27177

Merged
merged 1 commit into from
Jul 24, 2015

Conversation

echochamber
Copy link
Contributor

Was browsing somebody else's code and came across a snippet using labels. Looking around, it seems like there was an example for this in rustbyexample but none in trpl.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

r? @steveklabnik

@@ -88,6 +88,18 @@ for x in 0..10 {
}
```

You may also encounter situations where you have nested loops and need to specify which one your `break` or `continue` statement is for. Like most other languages, by default a `break` or `continue` will apply to innermost loop. In a sitation where you would like to a `break` or `continue` for one of the outer loops, you can use labels to specify which loop the `break` or `continue` statement applies to. This will only print when both x and y are odd:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you wrap this line please? Also, x and y need to be in graves for highlighting

@steveklabnik
Copy link
Member

Thanks! two nits and then r=me

@echochamber
Copy link
Contributor Author

r? @steveklabnik

Updated with fixes for your comments.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 22, 2015

📌 Commit c80bff0 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thank you!

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 23, 2015
Was browsing somebody else's code and came across a snippet using labels. Looking around, it seems like there was an example for this in [rustbyexample](http://rustbyexample.com/flow_control/loop/nested.html) but none in trpl.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 24, 2015
Was browsing somebody else's code and came across a snippet using labels. Looking around, it seems like there was an example for this in [rustbyexample](http://rustbyexample.com/flow_control/loop/nested.html) but none in trpl.
bors added a commit that referenced this pull request Jul 24, 2015
@bors bors merged commit c80bff0 into rust-lang:master Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants