Add diagnostics for E0120 #27220
Merged
Add diagnostics for E0120 #27220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| ``` | ||
|
|
||
| Only structs are allowed to implement Drop. That being the case, a solution for |
There was a problem hiding this comment.
Oops, good catch!
|
I think there are many use cases we should explore and give alternatives to:
|
|
Alright, I'll have a look at that tomorrow. |
|
I've had a stab at it, but would appreciate a review to make sure I'm going in the direction you were thinking of :-) |
|
|
||
| ``` | ||
| trait MyTrait {} | ||
| struct MyWrapper<'a> { foo: &'a MyTrait } |
There was a problem hiding this comment.
leave a comment // or Box<MyTrait>, if you wanted an owned trait object
|
looks good to me! |
AlisdairO
force-pushed
the
diagnostics120
branch
from
b47be9e to
e668175
Compare
|
Done, and squashed! |
|
@bors r+ rollup |
|
📌 Commit e668175 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 24, 2015
…arth As title! I should probably be bunching these up a bit more, but I'm not sure when my time is going to disappear on me. Once my schedule stabilises I'll try to start batching them into larger PRs. Part of rust-lang#24407. r? @Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title!
I should probably be bunching these up a bit more, but I'm not sure when my time is going to disappear on me. Once my schedule stabilises I'll try to start batching them into larger PRs.
Part of #24407.
r? @Manishearth