Fix for issue #27008 #27244
Fix for issue #27008 #27244
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @eddyb |
| @@ -967,6 +967,12 @@ pub fn eval_const_expr_partial<'tcx>(tcx: &ty::ctxt<'tcx>, | |||
| Some(def::DefVariant(enum_def, variant_def, _)) => { | |||
| (lookup_variant_by_id(tcx, enum_def, variant_def), None) | |||
| } | |||
| Some(def::DefStruct(struct_def)) => { | |||
| if ast_util::is_local(struct_def) { | |||
| return Ok(ConstVal::Struct(struct_def.node)) | |||
There was a problem hiding this comment.
Why restrict this to same-crate struct types? It should work fine either way.
…for unit-struct path expressions. Fixes rust-lang#27008
|
Thank you! @bors r+ rollup |
|
📌 Commit e981311 has been approved by |
Hi all. This is my first contribution to Rust and fixes an issue causing an invalid error message to be presented to the user when using unit struct as length of a repeat expression, issue rust-lang#27008. The solution is based on suggestions by @oli-obk, but as I'm a complete newbie to this, I have no clue if I got them right :) The biggest concern I have is that if the `NodeId` I'm returning is the correct one or not (it's not meaningful in this case but I think it would be nice to get it right).
Hi all.
This is my first contribution to Rust and fixes an issue causing an invalid error message to be presented to the user when using unit struct as length of a repeat expression, issue #27008. The solution is based on suggestions by @oli-obk, but as I'm a complete newbie to this, I have no clue if I got them right :)
The biggest concern I have is that if the
NodeIdI'm returning is the correct one or not (it's not meaningful in this case but I think it would be nice to get it right).