Only print parameters with elided lifetimes in elision error messages. #33708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
nham
force-pushed
the
zero-elided-lifetimes
branch
from
dc9bab2
to
36ff0a9
Compare
When displaying the function parameters for a lifetime elision error message, this changes it to first filter out the parameters that don't have elided lifetimes. Fixes rust-lang#30255.
nham
force-pushed
the
zero-elided-lifetimes
branch
from
36ff0a9
to
7fef162
Compare
| true | ||
| } else { | ||
| false | ||
| }; |
There was a problem hiding this comment.
This is just let any_lifetimes = elided_len > 0.
There was a problem hiding this comment.
Better, replace !any_lifetimes below with elided_len == 0.
There was a problem hiding this comment.
Good point. I've done this.
|
@bors r+ |
|
📌 Commit a50c82b has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 19, 2016
Only print parameters with elided lifetimes in elision error messages. When displaying the function parameters for a lifetime elision error message, this changes it to first filter out the parameters that don't have elided lifetimes. Fixes rust-lang#30255.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying the function parameters for a lifetime elision error message,
this changes it to first filter out the parameters that don't have elided
lifetimes.
Fixes #30255.