Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust syntax coloring for some ignore, should-panic and no-run snippets. #33721

Merged
merged 1 commit into from
May 19, 2016
Merged

Rust syntax coloring for some ignore, should-panic and no-run snippets. #33721

merged 1 commit into from
May 19, 2016

Conversation

royalstream
Copy link
Contributor

In the book, some code blocks were missing the rust specifier which is needed for them to highlight correctly.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Manishearth
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented May 18, 2016

📌 Commit c951718 has been approved by Manishearth

Manishearth added a commit to Manishearth/rust that referenced this pull request May 19, 2016
…hts, r=Manishearth

Rust syntax coloring for some ignore, should-panic and no-run snippets.

In the book, some code blocks were missing the `rust` specifier which is needed for them to highlight correctly.
bors added a commit that referenced this pull request May 19, 2016
Rollup of 10 pull requests

- Successful merges: #33353, #33611, #33696, #33698, #33705, #33708, #33712, #33720, #33721, #33730
- Failed merges:
@bors bors merged commit c951718 into rust-lang:master May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants