Clarified that let(mut x, y) = only makes x mutable, not y
#33720
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Great! Thanks so much, and sorry about the procedural issues. @bors: r+ rollup |
|
📌 Commit 98f1c35 has been approved by |
| @@ -55,6 +55,8 @@ fn foo(mut x: i32) { | |||
| # } | |||
| ``` | |||
|
|
|||
| Note that here, the `x` is mutable, but not the `y`. | |||
There was a problem hiding this comment.
The previous paragraph already has "Note that" -- maybe this one can simply be put into the code example as a comment?
There was a problem hiding this comment.
I can't see that in the master. But one easy fix is to change "Note that here" to "Here".
…abnik Clarified that `let(mut x, y) =` only makes x mutable, not y Closes rust-lang#33716
Closes #33716