Skip to content

add documentation on howto build just rustc without libstd to the build system #34007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2016
Merged

add documentation on howto build just rustc without libstd to the build system #34007

merged 1 commit into from
Jun 7, 2016

Conversation

flo-l
Copy link
Contributor

@flo-l flo-l commented Jun 1, 2016

I searched for days until I found this, maybe this helps other poor souls 😂

for reference #33990

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@flo-l
Copy link
Contributor Author

flo-l commented Jun 1, 2016

cc @alexcrichton

@alexcrichton
Copy link
Member

We may want to replace the "x86_64-unknown-linux-gnu" here with "$host" perhaps as it'll differ depending on where you're compiling. The explanation may also want to be accompanied with a warning indicating that this may not work as the standard library really does need to be recompiled to be guaranteed to work.

@alexcrichton alexcrichton assigned alexcrichton and unassigned aturon Jun 2, 2016
@flo-l
Copy link
Contributor Author

flo-l commented Jun 2, 2016

good catch with x86_64-unknown-linux-gnu, fixed it and added some more words of warning regarding libstd.

@@ -62,6 +62,7 @@
# * tidy - Basic style check, show highest rustc error code and
# the status of language and lib features
# * rustc-stage$(stage) - Only build up to a specific stage
# * x86_64-unknown-linux-gnu/stage1/bin/rustc - Only build stage1 rustc, not libstd.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more "$host" here

Verified

This commit was signed with the committer’s verified signature. The key has expired.
6543 6543
…ld system
@flo-l
Copy link
Contributor Author

flo-l commented Jun 5, 2016

fixed again!

@alexcrichton
Copy link
Member

@bors: r+ 4e87986

@eddyb
Copy link
Member

eddyb commented Jun 6, 2016

@bors rollup

@bors
Copy link
Collaborator

bors commented Jun 6, 2016

⌛ Testing commit 4e87986 with merge 1ef5f79...

bors added a commit that referenced this pull request Jun 6, 2016

Verified

This commit was signed with the committer’s verified signature.
add documentation on howto build just rustc without libstd to the build system

I searched for days until I found this, maybe this helps other poor souls 😂

for reference #33990
@bors
Copy link
Collaborator

bors commented Jun 6, 2016

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented Jun 6, 2016

⌛ Testing commit 4e87986 with merge 71efa91...

bors added a commit that referenced this pull request Jun 6, 2016

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
add documentation on howto build just rustc without libstd to the build system

I searched for days until I found this, maybe this helps other poor souls 😂

for reference #33990
@bors
Copy link
Collaborator

bors commented Jun 6, 2016

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented Jun 6, 2016

⌛ Testing commit 4e87986 with merge 3bedec0...

bors added a commit that referenced this pull request Jun 6, 2016
add documentation on howto build just rustc without libstd to the build system

I searched for days until I found this, maybe this helps other poor souls 😂

for reference #33990
@bors
Copy link
Collaborator

bors commented Jun 6, 2016

⛄ The build was interrupted to prioritize another pull request.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 7, 2016
…richton

add documentation on howto build just rustc without libstd to the build system

I searched for days until I found this, maybe this helps other poor souls 😂

for reference rust-lang#33990
bors added a commit that referenced this pull request Jun 7, 2016
Rollup of 13 pull requests

- Successful merges: #33645, #33897, #33945, #34007, #34060, #34070, #34094, #34098, #34099, #34104, #34124, #34125, #34138
- Failed merges:
@bors bors merged commit 4e87986 into rust-lang:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants