-
Notifications
You must be signed in to change notification settings - Fork 13.3k
add documentation on howto build just rustc without libstd to the build system #34007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
We may want to replace the "x86_64-unknown-linux-gnu" here with "$host" perhaps as it'll differ depending on where you're compiling. The explanation may also want to be accompanied with a warning indicating that this may not work as the standard library really does need to be recompiled to be guaranteed to work. |
good catch with x86_64-unknown-linux-gnu, fixed it and added some more words of warning regarding libstd. |
@@ -62,6 +62,7 @@ | |||
# * tidy - Basic style check, show highest rustc error code and | |||
# the status of language and lib features | |||
# * rustc-stage$(stage) - Only build up to a specific stage | |||
# * x86_64-unknown-linux-gnu/stage1/bin/rustc - Only build stage1 rustc, not libstd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more "$host" here
…ld system
fixed again! |
@bors rollup |
add documentation on howto build just rustc without libstd to the build system I searched for days until I found this, maybe this helps other poor souls 😂 for reference #33990
⛄ The build was interrupted to prioritize another pull request. |
⌛ Testing commit 4e87986 with merge 71efa91... |
add documentation on howto build just rustc without libstd to the build system I searched for days until I found this, maybe this helps other poor souls 😂 for reference #33990
⛄ The build was interrupted to prioritize another pull request. |
add documentation on howto build just rustc without libstd to the build system I searched for days until I found this, maybe this helps other poor souls 😂 for reference #33990
⛄ The build was interrupted to prioritize another pull request. |
…richton add documentation on howto build just rustc without libstd to the build system I searched for days until I found this, maybe this helps other poor souls 😂 for reference rust-lang#33990
I searched for days until I found this, maybe this helps other poor souls 😂
for reference #33990