Rollup of 13 pull requests #34139
Merged
Rollup of 13 pull requests #34139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pattern cannot be a str because str's pattern is not double-ended.
The original description suggests that the original `Rc<T>` itself is downgraded, which doesn't seem to be what the code does. At the same time, `Rc` is one of those types that can do weird things with only a shared reference, so I thought it would be good to be clear.
We are using getMCTargetInfo which is 3.7+
Technically, this is a [breaking-change], but I'm not sure what the policy for -Z flags is (especially unused ones).
* In "... name as another binding, that's currently in scope, will ...", ", that's currently in scope, " is not a parenthetical element, and the commas can be omitted. * Other minor changes.
…oc, r=steveklabnik Correct the docs on str::trim_matches This pattern cannot be a str because str's pattern is not double-ended.
run rustfmt on test/run-fail folder
run rustfmt on libpanic_unwind folder
…richton add documentation on howto build just rustc without libstd to the build system I searched for days until I found this, maybe this helps other poor souls 😂 for reference rust-lang#33990
Improved documentation for tests/ directory This ambigouity problem was already discussed in the [forums](https://users.rust-lang.org/t/problem-using-external-modules-inside-integration-test-submodule/5312/6).
…ated-attribute, r=steveklabnik Update reference to indicate stabilization of `deprecated` attribute. None
…s, r=steveklabnik Minor changes to variable bindings chapter * In "*... name as another binding, that's currently in scope, will ...*", *" that's currently in scope"* is not a parenthetical element, and the commas can be omitted. * Other minor changes.
Update rc.rs The original description suggests that the original `Rc<T>` itself is downgraded, which doesn't seem to be what the code does. At the same time, `Rc` is one of those types that can do weird things with only a shared reference, so I thought it would be good to be clear.
…veklabnik Add missing space before parenthesis.
Require LLVM 3.7 We are using getMCTargetInfo which is 3.7+. I’m not sure whether 3.7 works though. Fixes rust-lang#34103 r? @alexcrichton
…s, r=sanxiyn Remove old -Z options that do nothing Technically, this is a [breaking-change], but I'm not sure what the policy for -Z flags is (especially unused ones).
…klabnik Noted that shadowing never destroys a value Fixes issue rust-lang#33887 r? @steveklabnik
Bug/bool colors This is actually rust-lang#33661 @steveklabnik, sorry about this, github ate my homework
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit a0bf3b8 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecatedattribute. #34070, Minor changes to variable bindings chapter #34094, Update rc.rs #34098, Add missing space before parenthesis. #34099, Require LLVM 3.7 #34104, Remove old -Z options that do nothing #34124, Noted that shadowing never destroys a value #34125, Bug/bool colors #34138