Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #34139

Merged
merged 28 commits into from
Jun 7, 2016
Merged

Rollup of 13 pull requests #34139

merged 28 commits into from
Jun 7, 2016

Conversation

withoutboats and others added 28 commits May 14, 2016 17:58
This pattern cannot be a str because str's pattern is not double-ended.
The original description suggests that the original `Rc<T>` itself is downgraded, which doesn't seem to be what the code does. At the same time, `Rc` is one of those types that can do weird things with only a shared reference, so I thought it would be good to be clear.
We are using getMCTargetInfo which is 3.7+
Technically, this is a [breaking-change], but I'm not sure what the
policy for -Z flags is (especially unused ones).
* In "... name as another binding, that's currently in scope, will ...", ",
  that's currently in scope, " is not a parenthetical element, and the commas
  can be omitted.

* Other minor changes.
…oc, r=steveklabnik

Correct the docs on str::trim_matches

This pattern cannot be a str because str's pattern is not double-ended.
…richton

add documentation on howto build just rustc without libstd to the build system

I searched for days until I found this, maybe this helps other poor souls 😂

for reference rust-lang#33990
Improved documentation for tests/ directory

This ambigouity problem was already discussed in the [forums](https://users.rust-lang.org/t/problem-using-external-modules-inside-integration-test-submodule/5312/6).
…ated-attribute, r=steveklabnik

Update reference to indicate stabilization of `deprecated` attribute.

None
…s, r=steveklabnik

Minor changes to variable bindings chapter

* In "*... name as another binding, that's currently in scope, will ...*", *"
  that's currently in scope"* is not a parenthetical element, and the commas
  can be omitted.

* Other minor changes.
Update rc.rs

The original description suggests that the original `Rc<T>` itself is downgraded, which doesn't seem to be what the code does. At the same time, `Rc` is one of those types that can do weird things with only a shared reference, so I thought it would be good to be clear.
…veklabnik

Add missing space before parenthesis.
Require LLVM 3.7

We are using getMCTargetInfo which is 3.7+. I’m not sure whether 3.7 works though.

Fixes rust-lang#34103

r? @alexcrichton
…s, r=sanxiyn

Remove old -Z options that do nothing

Technically, this is a [breaking-change], but I'm not sure what the policy for -Z flags is (especially unused ones).
…klabnik

Noted that shadowing never destroys a value

Fixes issue rust-lang#33887

r? @steveklabnik
Bug/bool colors

This is actually rust-lang#33661 @steveklabnik, sorry about this, github ate my homework
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member Author

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Jun 7, 2016

📌 Commit a0bf3b8 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Jun 7, 2016

⌛ Testing commit a0bf3b8 with merge 39a523b...

bors added a commit that referenced this pull request Jun 7, 2016
Rollup of 13 pull requests

- Successful merges: #33645, #33897, #33945, #34007, #34060, #34070, #34094, #34098, #34099, #34104, #34124, #34125, #34138
- Failed merges:
@bors bors merged commit a0bf3b8 into rust-lang:master Jun 7, 2016
@steveklabnik steveklabnik deleted the rollup branch June 19, 2016 20:29
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet