Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference to indicate stabilization of deprecated attribute. #34070

Merged
merged 1 commit into from
Jun 7, 2016
Merged

Update reference to indicate stabilization of deprecated attribute. #34070

merged 1 commit into from
Jun 7, 2016

Conversation

chriskrycho
Copy link
Contributor

No description provided.

@@ -1983,6 +1983,7 @@ macro scope.

### Miscellaneous attributes

- `deprecated` - Allows using the `#[deprecated]` attribute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you put this in the wrong place? I don't understand what this is saying or why it belongs in this list. It used to be that #[feature(deprecated)] allowed use of #[deprecated], but it's stabilized now. Or did you mean the #[allow(deprecated)] attribute? But that allows usage of items marked deprecated, not use of #[deprecated] itself AFAIK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@durka, ah, I see. I just moved the existing reference to deprecated; I missed seeing that the verbiage needed to be changed as well. As the structure of the document currently stands, this is the list of attributes which aren't specifically scoped to crates, modules, functions, items, etc.

It looks like the wording should presumably be altered to say something like this:

deprecated - Marks the item as deprecated.

Presumably that should be expanded a bit, too; what's the actual syntax for the use of the deprecated attribute—version number and comment? I can't find that attribute itself documented anywhere. If someone can give me the relevant info, I'll fill it out with that.

(Which, of course, is exactly why we need rust-lang/rfcs#1636. 😉)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax is #[deprecated(since = "crate version", note = "...")], both fields optional. Documented in the RFC and the test suite but it really needs to be in the reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated accordingly.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Thanks Chris!

@bors
Copy link
Contributor

bors commented Jun 6, 2016

📌 Commit 2745d3e has been approved by steveklabnik

@chriskrycho
Copy link
Contributor Author

👍🏼😊

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 7, 2016
…ated-attribute, r=steveklabnik

Update reference to indicate stabilization of `deprecated` attribute.

None
bors added a commit that referenced this pull request Jun 7, 2016
Rollup of 13 pull requests

- Successful merges: #33645, #33897, #33945, #34007, #34060, #34070, #34094, #34098, #34099, #34104, #34124, #34125, #34138
- Failed merges:
@bors bors merged commit 2745d3e into rust-lang:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants