Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A disclaimer about keywords. #34370

Merged
merged 1 commit into from
Aug 17, 2016
Merged

A disclaimer about keywords. #34370

merged 1 commit into from
Aug 17, 2016

Conversation

steveklabnik
Copy link
Member

Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.

@rust-highfive
Copy link
Collaborator

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@durka
Copy link
Contributor

durka commented Jun 19, 2016

Can we italicize (or something) the ones that are reserved yet unused?

@killercup
Copy link
Member

Did you mean to add the grammar/verify file?

@Manishearth
Copy link
Member

r=me with the bin file removed and possible italicization

@matklad
Copy link
Member

matklad commented Jun 20, 2016

Can we italicize (or something) the ones that are reserved yet unused?

Perhaps just use two alphabetically sorted tables: reserved words and keywords?

@alexcrichton
Copy link
Member

@steveklabnik ping on this review comment

@dns2utf8
Copy link
Contributor

I think the grammar/verify should not be in the commit, as it is generated on demand (#34994) and in the grammar/.gitignore

@steveklabnik
A disclaimer about keywords.
85bbbad 
Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
@steveklabnik
Copy link
Member Author

@bors: r=Manishearth rollup

I want to land this patch without worrying about "how are we gonna keep the reference up to date with keywords being implemented," and they have fantastic error messages at the moment.

@bors
Copy link
Contributor

bors commented Aug 15, 2016

📌 Commit 85bbbad has been approved by Manishearth

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Rollup merge of rust-lang#34370 - steveklabnik:keyword-ref-mention, r…
5c940b1 
…=Manishearth

A disclaimer about keywords.

Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
@sophiajt sophiajt mentioned this pull request Aug 17, 2016
Closed
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of #35743 - jonathandturner:rollup, r=jonathandturner
b28ffa5 
Rollup of 24 pull requests

- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35691, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Rollup merge of rust-lang#34370 - steveklabnik:keyword-ref-mention, r…
e83bff9 
…=Manishearth

A disclaimer about keywords.

Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
@sophiajt sophiajt mentioned this pull request Aug 17, 2016
Merged
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of #35747 - jonathandturner:rollup, r=jonathandturner
7ac11ca 
Rollup of 23 pull requests

- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
@bors bors merged commit 85bbbad into rust-lang:master Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@steveklabnik @rust-highfive @durka @killercup @Manishearth @matklad @alexcrichton @dns2utf8 @bors