Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 23 pull requests #35747

Merged
merged 51 commits into from
Aug 17, 2016
Merged

Rollup of 23 pull requests #35747

merged 51 commits into from
Aug 17, 2016

Conversation

urschrei and others added 30 commits August 11, 2016 20:05
Explain why Rust does not implement traits for large arrays.

Explain why most methods are implemented on slices rather than arrays.
The spacing seems inconsistent with existing style conventions.
Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
I'm only making this change in one place so that people can express
their preferences for this stylistic change. If/when this change is
approved I'll go ahead and translate the rest of the `std::ops`
examples.
Display all the remaining items of the iterator, similar to the `Debug`
implementation for `core::slice::Iter`:

https://github.com/rust-lang/rust/blob/f0bab98695f0a4877daabad9a5b0ba3e66121392/src/libcore/slice.rs#L930-L937

Using the `as_slice` method that was added in:

rust-lang#35447
…=Manishearth

A disclaimer about keywords.

Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
…andturner

Update compiler error 0030 to use new error format.

Part of rust-lang#35233,
Addresses rust-lang#35204

r? @jonathandturner
Jonathan Turner added 9 commits August 17, 2016 06:25
…ed, r=steveklabnik

expound on limitations of Rust's trait-based operator overloading

Part of rust-lang#29330
…tln, r=GuillaumeGomez

accumulate into vector and assert, instead of printing

I'm only making this change in one place so that people can express
their preferences for this stylistic change. If/when this change is
approved I'll go ahead and translate the rest of the `std::ops`
examples.
…xcrichton

Implement `Debug` for `std::vec::IntoIter`.

Display all the remaining items of the iterator, similar to the `Debug`
implementation for `core::slice::Iter`:

https://github.com/rust-lang/rust/blob/f0bab98695f0a4877daabad9a5b0ba3e66121392/src/libcore/slice.rs#L930-L937

Using the `as_slice` method that was added in:

rust-lang#35447
…sakis

RUST_NEW_ERROR_FORMAT is no more

So stop setting the environment variable.
Use UI test to test spans, instead of forced line break

There must be lots more, but these are what I could easily find.
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@sophiajt
Copy link
Contributor Author

@bors r+ r=10

@bors
Copy link
Contributor

bors commented Aug 17, 2016

📌 Commit c216617 has been approved by 10

@bors
Copy link
Contributor

bors commented Aug 17, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 17, 2016

📌 Commit c216617 has been approved by jonathandturner

@sophiajt
Copy link
Contributor Author

@bors p=10

@sophiajt
Copy link
Contributor Author

@bors r=jonathandturner

@bors
Copy link
Contributor

bors commented Aug 17, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 17, 2016

📌 Commit c216617 has been approved by jonathandturner

@bors
Copy link
Contributor

bors commented Aug 17, 2016

⌛ Testing commit c216617 with merge 7ac11ca...

bors added a commit that referenced this pull request Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.