accumulate into vector and assert, instead of printing #35695

matthew-piziak · 2016-08-15T22:06:34Z

I'm only making this change in one place so that people can express
their preferences for this stylistic change. If/when this change is
approved I'll go ahead and translate the rest of the std::ops
examples.

I'm only making this change in one place so that people can express their preferences for this stylistic change. If/when this change is approved I'll go ahead and translate the rest of the `std::ops` examples.

rust-highfive · 2016-08-15T22:06:43Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

matthew-piziak · 2016-08-15T22:06:54Z

r? @steveklabnik

GuillaumeGomez · 2016-08-15T22:08:54Z

Ah nice, thanks!

@bors: r+ rollup

bors · 2016-08-15T22:08:56Z

📌 Commit c9f2055 has been approved by GuillaumeGomez

Limeth · 2016-08-15T22:19:53Z

src/libcore/iter/range.rs

-    /// 4
-    /// 6
-    /// 8
+    /// let result: Vec<_> = (0..10).step_by(2).take(10).collect();


Shouldn't this have .take(5) instead?

matthew-piziak · 2016-08-15T22:32:01Z

@Limeth Actually this example doesn't need a take call at all. Fixed. :)

r? @GuillaumeGomez

@steveklabnik

GuillaumeGomez · 2016-08-15T23:15:24Z

I learnt something new today. Thanks again!

@bors: r+ rollup

bors · 2016-08-15T23:15:25Z

📌 Commit 2c9a1d9 has been approved by GuillaumeGomez

…tln, r=GuillaumeGomez accumulate into vector and assert, instead of printing I'm only making this change in one place so that people can express their preferences for this stylistic change. If/when this change is approved I'll go ahead and translate the rest of the `std::ops` examples.

Rollup of 24 pull requests - Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35691, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731 - Failed merges: #35395

…tln, r=GuillaumeGomez accumulate into vector and assert, instead of printing I'm only making this change in one place so that people can express their preferences for this stylistic change. If/when this change is approved I'll go ahead and translate the rest of the `std::ops` examples.

Rollup of 23 pull requests - Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731 - Failed merges: #35395

PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.

…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.

PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`. add `fn main` wrappers to enable Rust Playground "Run" button

…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.

PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`. add `fn main` wrappers to enable Rust Playground "Run" button

…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.

accumulate into vector and assert, instead of printing

c9f2055

I'm only making this change in one place so that people can express their preferences for this stylistic change. If/when this change is approved I'll go ahead and translate the rest of the `std::ops` examples.

rust-highfive assigned aturon Aug 15, 2016

rust-highfive assigned steveklabnik and unassigned aturon Aug 15, 2016

Limeth reviewed Aug 15, 2016
View reviewed changes

remove .take(10) from Range example

2c9a1d9

rust-highfive assigned GuillaumeGomez and unassigned steveklabnik Aug 15, 2016

sophiajt mentioned this pull request Aug 17, 2016

Rollup of 24 pull requests #35743

Closed

sophiajt mentioned this pull request Aug 17, 2016

Rollup of 23 pull requests #35747

Merged

matthew-piziak mentioned this pull request Aug 17, 2016

accumulate vector and assert for RangeFrom and RangeInclusive examples #35758

Merged

bors merged commit 2c9a1d9 into rust-lang:master Aug 17, 2016

matthew-piziak deleted the vec-assert-over-println branch August 17, 2016 20:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

accumulate into vector and assert, instead of printing #35695

accumulate into vector and assert, instead of printing #35695

matthew-piziak commented Aug 15, 2016

rust-highfive commented Aug 15, 2016

matthew-piziak commented Aug 15, 2016

GuillaumeGomez commented Aug 15, 2016

bors commented Aug 15, 2016

Limeth Aug 15, 2016

matthew-piziak commented Aug 15, 2016

GuillaumeGomez commented Aug 15, 2016

bors commented Aug 15, 2016

accumulate into vector and assert, instead of printing #35695

accumulate into vector and assert, instead of printing #35695

Conversation

matthew-piziak commented Aug 15, 2016

rust-highfive commented Aug 15, 2016

matthew-piziak commented Aug 15, 2016

GuillaumeGomez commented Aug 15, 2016

bors commented Aug 15, 2016

Limeth Aug 15, 2016

Choose a reason for hiding this comment

matthew-piziak commented Aug 15, 2016

GuillaumeGomez commented Aug 15, 2016

bors commented Aug 15, 2016