Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0023 to the new format #35446

Merged
merged 1 commit into from
Aug 10, 2016
Merged

Conversation

pcn
Copy link
Contributor

@pcn pcn commented Aug 7, 2016

Added some extra code to check for the appropriate ending for numbers ==
1 vs. not 1 in error messages.

Added an extra test so that the plural suffix is seen and exercised.

Added some extra code to check for the appropriate ending for numbers ==
1 vs. not 1 in error messages.

Added an extra test so that the plural suffix is seen and exercised.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pcn
Copy link
Contributor Author

pcn commented Aug 7, 2016

This is for #35196

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

Looks good.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2016

📌 Commit 2c563c6 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
…onathandturner

Update E0023 to the new format

Added some extra code to check for the appropriate ending for numbers ==
1 vs. not 1 in error messages.

Added an extra test so that the plural suffix is seen and exercised.
bors added a commit that referenced this pull request Aug 7, 2016
Rollup of 6 pull requests

- Successful merges: #35396, #35402, #35446, #35466, #35470, #35475
- Failed merges: #35395, #35415
@bors
Copy link
Contributor

bors commented Aug 8, 2016

⌛ Testing commit 2c563c6 with merge 9960ad7...

@bors
Copy link
Contributor

bors commented Aug 8, 2016

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton
Copy link
Member

@bors: retry

  • not sure why...

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 8, 2016
…onathandturner

Update E0023 to the new format

Added some extra code to check for the appropriate ending for numbers ==
1 vs. not 1 in error messages.

Added an extra test so that the plural suffix is seen and exercised.
@pcn
Copy link
Contributor Author

pcn commented Aug 9, 2016

The two compile-failed warnings don't appear to be related to this PR :person_frowning:

@sophiajt
Copy link
Contributor

sophiajt commented Aug 9, 2016

@pcn - the build bots were down yesterday morning. If you click on the compile link instead of the warnings, you can see a bunch of llvm errors. Not sure why it happened, but they seem to be working now.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
…onathandturner

Update E0023 to the new format

Added some extra code to check for the appropriate ending for numbers ==
1 vs. not 1 in error messages.

Added an extra test so that the plural suffix is seen and exercised.
bors added a commit that referenced this pull request Aug 10, 2016
@bors bors merged commit 2c563c6 into rust-lang:master Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants