Fix E0132 error display #35477
Merged
Fix E0132 error display #35477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -261,9 +261,10 @@ fn check_start_fn_ty(ccx: &CrateCtxt, | |||
| match it.node { | |||
| hir::ItemFn(_,_,_,_,ref ps,_) | |||
| if ps.is_parameterized() => { | |||
| struct_span_err!(tcx.sess, start_span, E0132, | |||
| let sp = ps.span().unwrap(); | |||
There was a problem hiding this comment.
This looks okay, though I'm not 100% sure there's always a span if it's .is_parameterized().
We could support a fallback with something like:
let sp = if let Some(span) = ps.span() { span } else { start_span };
|
Looks okay, though I left a comment on one way we might allow it to fallback to the larger span if there's ever a case we don't have the smaller span. |
GuillaumeGomez
force-pushed
the
fix_E0132
branch
from
1861fc7
to
e40df1c
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit e40df1c has been approved by |
|
⌛ Testing commit e40df1c with merge b605013... |
|
💔 Test failed - auto-win-gnu-64-opt |
|
That is quite the strange error! |
|
@bors retry |
|
@bors: retry
|
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 8, 2016
…ndturner Fix E0132 error display Error and note now use the same span. r? @jonathandturner
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 10, 2016
…ndturner Fix E0132 error display Error and note now use the same span. r? @jonathandturner
bors
added a commit
that referenced
this pull request
Aug 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error and note now use the same span.
r? @jonathandturner