Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated E0087 to new format #35449

Merged
merged 1 commit into from Aug 10, 2016
Merged

Updated E0087 to new format #35449

merged 1 commit into from Aug 10, 2016

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2016

Part of #35233. r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

Thanks for the PR!

Can you also update the corresponding unit test(s) to test for the new label? You may need to add a couple tests so that you can test for the variations.

@ghost
Copy link
Author

ghost commented Aug 7, 2016

I added a note to src/test/compile-fail/E0087.rs to match the new error format

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

Great! One last thing, since it's pretty small, can you squash your 2 commits into 1?

After that, I think it'll be ready.

@ghost
Copy link
Author

ghost commented Aug 7, 2016

Sure Jonathan :)

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2016

📌 Commit 8b111a7 has been approved by jonathandturner

@bors
Copy link
Contributor

bors commented Aug 8, 2016

⌛ Testing commit 8b111a7 with merge adaf9f9...

@bors
Copy link
Contributor

bors commented Aug 8, 2016

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton
Copy link
Member

@bors: retry

  • not sure why...

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 8, 2016
@ghost
Copy link
Author

ghost commented Aug 9, 2016

It is my fault? D:

@sophiajt
Copy link
Contributor

sophiajt commented Aug 9, 2016

@poveda-ruiz - there was an extra space at the end of one of your lines. I've merged this PR in with a bunch of other PRs, so I'm just going to fix it on my end.

For your next one, you can run:

python src/bootstrap/bootstrap.py --stage 1 --step check-tidy

@ghost
Copy link
Author

ghost commented Aug 9, 2016

Damn, sorry :( yeah aparently I forgot to run it after correcting the unit test

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
bors added a commit that referenced this pull request Aug 10, 2016
@bors bors merged commit 8b111a7 into rust-lang:master Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants