-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing links and examples for path modules and structs #38946
Conversation
Looks great! Thanks! @bors r+ rollup |
📌 Commit 8c40a0a has been approved by |
//! This module provides two types, `PathBuf` and `Path` (akin to `String` and | ||
//! `str`), for working with paths abstractly. These types are thin wrappers | ||
//! around `OsString` and `OsStr` respectively, meaning that they work directly | ||
//! This module provides two types, [`PathBuf`] and [`Path`] (akin to [`String`] and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Path] (akin to...)
seems to be interpreted as a Markdown link, causing Travis failure in linkcheck.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well found!
@bors r- |
8c40a0a
to
0938b28
Compare
Updated. |
/// # Examples | ||
/// | ||
/// ```no_run | ||
/// use std::path::{Path, PathBuf}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused import: PathBuf
/// # Examples | ||
/// | ||
/// ```no_run | ||
/// use std::path::{Path, PathBuf}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused import: PathBuf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(certainly github bug actually)
0938b28
to
8ab66bf
Compare
Updated. |
8ab66bf
to
44ab7f1
Compare
/// use std::path::Path; | ||
/// | ||
/// let path = Path::new("/foo/test/../test/bar.rs"); | ||
/// assert_eq!(path.canonicalize().unwrap(), PathBuf::from("/foo/test/bar.rs")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing import PathBuf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh damn, we'll never end it haha.
44ab7f1
to
28d1ac3
Compare
Updated. |
@bors r+ rollup |
📌 Commit 28d1ac3 has been approved by |
Add missing links and examples for path modules and structs r? @frewsxcv
r? @frewsxcv