Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant doc #38362

Merged
merged 1 commit into from
Jan 14, 2017
Merged

Instant doc #38362

merged 1 commit into from
Jan 14, 2017

Conversation

GuillaumeGomez
Copy link
Member

@frewsxcv
Copy link
Member

@bors delegate+ kmcallister

@bors
Copy link
Contributor

bors commented Dec 14, 2016

✌️ @GuillaumeGomez can now approve this pull request

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Dec 14, 2016

@bors delegate=kmcallister

@bors
Copy link
Contributor

bors commented Dec 14, 2016

✌️ @kmcallister can now approve this pull request

err.span_note(id_sp,
&format!("maybe move this module `{0}` to its own directory \
via `{0}/mod.rs`",
this_module));
paths.name));
if paths.path_exists {
err.span_note(id_sp,
&format!("... or maybe `use` the module `{}` instead \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change included?

@GuillaumeGomez
Copy link
Member Author

Updated.

@GuillaumeGomez
Copy link
Member Author

cc @frewsxcv

@GuillaumeGomez
Copy link
Member Author

Removed extra commit (page didn't update...).

///
/// # Examples
///
/// ```no_run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no_run?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there's a sleep, nevermind.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@frewsxcv
Copy link
Member

frewsxcv commented Jan 5, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 5, 2017

📌 Commit ec6ed34 has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented Jan 9, 2017

⌛ Testing commit ec6ed34 with merge f6d84bc...

@bors
Copy link
Contributor

bors commented Jan 9, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Jan 9, 2017 via email

@bors
Copy link
Contributor

bors commented Jan 9, 2017

⌛ Testing commit ec6ed34 with merge 2aed7fe...

@bors
Copy link
Contributor

bors commented Jan 9, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Jan 9, 2017 via email

@bors
Copy link
Contributor

bors commented Jan 10, 2017

⌛ Testing commit ec6ed34 with merge 224ba2f...

@bors
Copy link
Contributor

bors commented Jan 10, 2017

💔 Test failed - status-travis

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 10, 2017

@bors: retry

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 13, 2017
bors added a commit that referenced this pull request Jan 13, 2017
Rollup of 10 pull requests

- Successful merges: #38362, #38636, #38877, #38946, #38965, #38986, #38994, #38995, #39024, #39027
- Failed merges:
@bors bors merged commit ec6ed34 into rust-lang:master Jan 14, 2017
@GuillaumeGomez GuillaumeGomez deleted the instant_doc branch November 24, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants