-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.15 release notes #38966
1.15 release notes #38966
Conversation
* [Rust-ABI symbols are no longer exported from cdylibs][38117] | ||
* [The `--test` flag works with procedural macro crates][38107] | ||
* [Fix `extern "aapcs" fn` ABI][37814] | ||
* [The `-C no-stack-check` flag is deprecated][37637]. It does nothing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong issue/PR number. This refers to an issue titled "Using $crate with a proc macro"
* [Chinese characters display correctly in `fmt::Debug`][37855] | ||
* [Derive `Default` for `Duration`][37699] | ||
* [Support creation of anonymous pipes on WinXP/2k][37677] | ||
* [`copy_from_slice` is optimized for small copies][37573] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this PR didn't actually change copy_from_slice (but changed impl Read for &[u8]
), so that it special cases the single byte read case.
* [Don't clone in `UnificationTable::probe`][37848] | ||
* [Remove `scope_auxiliary` to cut RSS by 10%][37764] | ||
* [Use small vectors in type walker][37760] | ||
* [Avoid unnecessary `mk_ty` calls in `Ty::super_fold_with`][37705] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As written this seems identical to the change four bullet points up. Granted, the PRs do basically the same thing, but throwing in a "more" somewhere would help — and indeed the linked PR is titled "Avoid more unnecessary ...".
* Basic procedural macros, including custom derive, aka "macros 1.1", are | ||
stable. This allows popular code-generating crates like Serde and Diesel to | ||
work ergonomically. [RFC 1681]. | ||
* [`..` may be used in struct patterns][36843]. [RFC 1492]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already mentioned in 1.14 release notes.
* [Link OpenSSL statically on OSX][cargo/3311] | ||
* [Apply new fingerprinting to build dir outputs][cargo/3310] | ||
* [Test for bad path overrides with summaries][cargo/3336] | ||
* [Require `cargo install --vers` takes a semver version][cargo/3338] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Require [...] to take [...]
* [Test for bad path overrides with summaries][cargo/3336] | ||
* [Require `cargo install --vers` takes a semver version][cargo/3338] | ||
* [Fix retrying crate downloads for network errors][cargo/3348] | ||
* [Implemented string lookup for `build.rustflags` config key][cargo/3356] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement*
lint, which is a warning in this release, and will become a hard error in the | ||
future. | ||
* [Rust-ABI symbols are no longer exported from cdylibs][38117] | ||
* [Once `Peekable` returns `None` it always does][37834] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a note about the upcoming struct reorder by @camlorn ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once
Peekable
returnsNone
it always does
This should be: if peekable peek
s a None, it will return that same None in peek or next without querying the underlying iterator. Peekable is still not fused.
All comments addressed. Thanks for review. @est31 re struct reordering, in these I don't mention any work in progress, only what's usable on stable. |
building Rust. | ||
* [Rust supports i686-unknown-openbsd][38086]. Tier 3 support. No testing or | ||
releases. | ||
* [Rust supports Redox, a pure-Rust OS][37702]. Tier 3 support. No testing or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackpot51 @ticki is this okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, yeah. Maybe we should wait until the next release for this bullet.
@bors: r+ |
📌 Commit c6b73d2 has been approved by |
stable. This allows popular code-generating crates like Serde and Diesel to | ||
work ergonomically. [RFC 1681]. | ||
* [Tuple structs may be empty. Unary and empty tuple structs may be instantiated | ||
with the brace][36868]. Part of [RFC 1506]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"with the brace" sounds weird. "with curly braces"?
[37602]: https://github.com/rust-lang/rust/pull/37602 | ||
[37613]: https://github.com/rust-lang/rust/pull/37613 | ||
[37615]: https://github.com/rust-lang/rust/pull/37615 | ||
[37627]: https://github.com/rust-lang/rust/pull/37672 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link target is right but the label is wrong (but it matches the link, so this doesn't actually matter).
Compiler Performance | ||
-------------------- | ||
|
||
* [Avoid unnecessary `mk_ty` calls in `Ty::super_fold_with`][37979] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link and the next one are swapped.
Language | ||
-------- | ||
|
||
* Basic procedural macros, including custom derive, aka "macros 1.1", are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just custom derive, not "including" custom derive, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the details I'm afraid, but I'll say that.
Thanks for the review @durka. |
@bors r+ |
📌 Commit a0a4af1 has been approved by |
⌛ Testing commit a0a4af1 with merge a58c6f6... |
💔 Test failed - status-travis |
1.15 release notes [Rundered](https://github.com/brson/rust/blob/relnotes/RELEASES.md#version-1150-2017-02-02). Lots of good stuff this release! Perf graphs: https://goo.gl/KSVFvF, https://goo.gl/K98g8M, https://goo.gl/H1gSoz, https://goo.gl/yZBV2p, https://goo.gl/ltURbb. Not much change 😿 r? @steveklabnik
… On Fri, Jan 20, 2017 at 4:38 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/193714169>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38966 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95F6z6w_iYYtlwt2Ls-FfAfO_3kkyks5rUKqsgaJpZM4Lf3p4>
.
|
⌛ Testing commit a0a4af1 with merge 8371487... |
@bors: retry
|
⌛ Testing commit a0a4af1 with merge 5bc4c06... |
@bors: retry
|
⌛ Testing commit a0a4af1 with merge 43f0020... |
@bors: retry
|
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
⌛ Testing commit a0a4af1 with merge 7b797c2... |
@bors: retry
|
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
The link for "Rust supports the MSP430" seems to be formatted incorrectly. |
Rundered.
Lots of good stuff this release!
Perf graphs: https://goo.gl/KSVFvF, https://goo.gl/K98g8M, https://goo.gl/H1gSoz, https://goo.gl/yZBV2p, https://goo.gl/ltURbb. Not much change 😿
r? @steveklabnik