travis: Get an emscripten builder online #39120
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@brson do you think now is the right time for this? Or should we perhaps wait on more solid support before it gets tier 2 status? |
|
I suspect allowing the emscripten commit to drift will be a recipe for sadness, but I don't mind trying if we can get it to pass bors. |
|
@bors r+ |
|
📌 Commit 759b4d2 has been approved by |
alexcrichton
force-pushed
the
emscripten-tests
branch
from
759b4d2 to
aa2e7f5
Compare
|
@bors: r=brson Oh hey looks like using a pinned version works! |
|
📌 Commit aa2e7f5 has been approved by |
This commit adds a new entry to the Travis matrix which will execute emscripten test suites. Along the way it updates a few bits of the test suite to continue passing on emscripten, such as: * Ignoring i128/u128 tests as they're presumably just not working (didn't investigate as to why) * Disabling a few process tests (not working on emscripten) * Ignore some num tests in libstd (rust-lang#39119) * Fix some warnings when compiling
alexcrichton
force-pushed
the
emscripten-tests
branch
from
aa2e7f5 to
e8f9d2d
Compare
|
@bors: r=brson |
|
📌 Commit e8f9d2d has been approved by |
travis: Get an emscripten builder online This commit adds a new entry to the Travis matrix which will execute emscripten test suites. Along the way it updates a few bits of the test suite to continue passing on emscripten, such as: * Ignoring i128/u128 tests as they're presumably just not working (didn't investigate as to why) * Disabling a few process tests (not working on emscripten) * Ignore some num tests in libstd (rust-lang#39119) * Fix some warnings when compiling
|
@bors: r- I forgot to add it to the matrix |
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
| @@ -45,7 +45,7 @@ pub fn check(build: &mut Build) { | |||
| let target = path.join(cmd); | |||
| let mut cmd_alt = cmd.to_os_string(); | |||
| cmd_alt.push(".exe"); | |||
| if target.exists() || | |||
| if target.is_file() || | |||
There was a problem hiding this comment.
Are there any reasons behind the mixed use of is_file() and exists() ?
Also, I don't quite understand what target.join(cmd_alt) is for; when we have, say, cmd=="python", path=="C:\\Python27", and thus cmd_alt=="python\.exe", are we not checking for C:\\Python27\python\python\.exe which I doubt make sense? I haven't tested it on any Windows PC, though.
There was a problem hiding this comment.
Nah they're likely mostly historical, this was changed as I wanted it to not pick up directories
This commit adds a new entry to the Travis matrix which will execute emscripten
test suites. Along the way it updates a few bits of the test suite to continue
passing on emscripten, such as:
investigate as to why)