Add an option to the parser so cfg'ed out modules can still be parsed #39145
Conversation
|
cc #36482 |
|
@bors r+ |
|
📌 Commit ac2c1da has been approved by |
|
Since you said asap, I am just going to grab ac2c1da and turn it into a syntex release. |
|
I released Syntex 0.56.0 based on ac2c1da48631bc183e07a89d73c88bae25af1fb9. |
|
@dtolnay Awesome, thank you! |
|
@dtolnay could you pick up the updated PR into Syntex please? Because I am a doofus who can't do basic logic :-( |
|
📌 Commit bd9c240 has been approved by |
|
thanks! |
|
urgh, another bug fix (at least I managed to test this one properly, so hopefully it'll be the last) @dtolnay sorry, to keep bothering you with this, but another fix when you have a minute, thanks! |
|
📌 Commit e0163a9 has been approved by |
|
This is your last chance! After this we're waiting for a successful nightly build. I released v0.56.2. |
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
|
☔ The latest upstream changes (presumably #39199) made this pull request unmergeable. Please resolve the merge conflicts. |
|
🔒 Merge conflict |
|
@bors: r=@jseyfried |
|
📌 Commit 44180c8 has been approved by |
|
⌛ Testing commit 44180c8 with merge 539501e... |
|
💔 Test failed - status-travis |
|
@bors: retry |
|
@bors: retry
* apparent travis bug?
…On Mon, Jan 23, 2017 at 7:40 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/194700548>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#39145 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AZt7Ln0qStrpiSewYLyUclVJijSks5rVXKxgaJpZM4LmU9v>
.
|
Add an option to the parser so cfg'ed out modules can still be parsed r? @jseyfried cc @dtolnay, @erickt it would be great if we could get this picked up into Syntex asap - it fixes a pretty nasty bug in Rustfmt.
|
☀️ Test successful - status-appveyor, status-travis |
r? @jseyfried
cc @dtolnay, @erickt it would be great if we could get this picked up into Syntex asap - it fixes a pretty nasty bug in Rustfmt.