-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #44482
Closed
Closed
Rollup of 8 pull requests #44482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL's Configure script is missing a shebang. On some platforms, execve falls back to execution with the shell. Some other platforms, like musl, will fail with an exec format error. Avoid this by calling perl explicitly (since it's a perl script).
This eliminates some warnings
…ulating CrateStore access in tcx.
This commit removes the `cstore_untracked` method, making the `CrateStore` trait object entirely private to the `ty/context.rs` module.
So that you can scroll down the list of labels along with these explanations.
Explicitly run perl for OpenSSL Configure OpenSSL's Configure script is missing a shebang. On some platforms, execve falls back to execution with the shell. Some other platforms, like musl, will fail with an exec format error. Avoid this by calling perl explicitly (since it's a perl script).
…etMisdreavus rustdoc: Don't counts ids twice when using --enable-commonmark cc @GuillaumeGomez r? @QuietMisdreavus
…=frewsxcv Clarify the behavior of UDP sockets wrt. multiple addresses in `connect` CC @frewsxcv rust-lang#22569 rust-lang#44209
…aelwoerister rustc: Make `CrateStore` private to `TyCtxt` This commit makes the `CrateStore` object private to the `ty/context.rs` module and also absent on the `Session` itself. cc rust-lang#44390 cc rust-lang#44341 (initial commit pulled and rebased from here)
…richton update mdbook This eliminates some warnings r? @alexcrichton
…ewsxcv Add doc example to String::as_mut_str Fixes rust-lang#44429.
Add short doc examples for str::from_utf8_mut Fixes rust-lang#44462
…on, r=Mark-Simulacrum Update label explanations Some of the newer labels weren't covered in CONTRIBUTING.md :) r? @Mark-Simulacrum
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=10 |
📌 Commit 92b633b has been approved by |
⌛ Testing commit 92b633b with merge 0b751a442fcd9d7816f46169168a3dba47552000... |
💔 Test failed - status-appveyor |
@bors retry |
⌛ Testing commit 92b633b with merge 32da592dc006bf5ae46173d269dc1f91112f8731... |
Merged
@bors r- |
@bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect
#44388, rustc: MakeCrateStore
private toTyCtxt
#44420, update mdbook #44430, Add doc example to String::as_mut_str #44453, Add short doc examples for str::from_utf8_mut #44472, Update label explanations #44476