rustdoc: Don't counts ids twice when using --enable-commonmark #44368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh awesome! I think the checks will fail because of one test I updated to make the original html-diff PR get merged though. If not, it means the PR is incomplete. |
|
In terms of "reducing false-positive render difference warnings", this has the same effect as #44350. What test are you thinking of that would be affected by this? |
|
I think the test change you're referring to was reverted in https://github.com/rust-lang/rust/pull/44238/files#diff-f6ee607baf038ab9752a5e4a57e92d4d so there's no problem. |
|
This passed travis, that's good enough for me. @bors r+ |
|
📌 Commit 55f9087 has been approved by |
|
@ollie27: Perfect then! |
alexcrichton
added
the
S-waiting-on-bors
frewsxcv
reviewed
Sep 10, 2017
| // Save the state of USED_ID_MAP so it only gets updated once even | ||
| // though we're rendering twice. | ||
| let orig_used_id_map = USED_ID_MAP.with(|map| map.borrow().clone()); | ||
| let hoedown_output = format!("{}", Markdown(md_text, RenderType::Hoedown)); |
There was a problem hiding this comment.
don't need to change it, but in the future, using .to_string() is the same as format!("{}", ..)
|
@bors rollup |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 11, 2017
…etMisdreavus rustdoc: Don't counts ids twice when using --enable-commonmark cc @GuillaumeGomez r? @QuietMisdreavus
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 11, 2017
…etMisdreavus rustdoc: Don't counts ids twice when using --enable-commonmark cc @GuillaumeGomez r? @QuietMisdreavus
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 13, 2017
…etMisdreavus rustdoc: Don't counts ids twice when using --enable-commonmark cc @GuillaumeGomez r? @QuietMisdreavus
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 14, 2017
…etMisdreavus rustdoc: Don't counts ids twice when using --enable-commonmark cc @GuillaumeGomez r? @QuietMisdreavus
10 tasks
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 15, 2017
…etMisdreavus rustdoc: Don't counts ids twice when using --enable-commonmark cc @GuillaumeGomez r? @QuietMisdreavus
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2018
Is it really time? Have our months, no, *years* of suffering come to an end? Are we finally able to cast off the pall of Hoedown? The weight which has dragged us down for so long? ----- So, timeline for those who need to catch up: * Way back in December 2016, [we decided we wanted to switch out the markdown renderer](rust-lang#38400). However, this was put on hold because the build system at the time made it difficult to pull in dependencies from crates.io. * A few months later, in March 2017, [the first PR was done, to switch out the renderers entirely](rust-lang#40338). The PR itself was fraught with CI and build system issues, but eventually landed. * However, not all was well in the Rustdoc world. During the PR and shortly after, we noticed [some differences in the way the two parsers handled some things](rust-lang#40912), and some of these differences were major enough to break the docs for some crates. * A couple weeks afterward, [Hoedown was put back in](rust-lang#41290), at this point just to catch tests that Pulldown was "spuriously" running. This would at least provide some warning about spurious tests, rather than just breaking spontaneously. * However, the problems had created enough noise by this point that just a few days after that, [Hoedown was switched back to the default](rust-lang#41431) while we came up with a solution for properly warning about the differences. * That solution came a few weeks later, [as a series of warnings when the HTML emitted by the two parsers was semantically different](rust-lang#41991). But that came at a cost, as now rustdoc needed proc-macro support (the new crate needed some custom derives farther down its dependency tree), and the build system was not equipped to handle it at the time. It was worked on for three months as the issue stumped more and more people. * In that time, [bootstrap was completely reworked](rust-lang#43059) to change how it ordered compilation, and [the method by which it built rustdoc would change](rust-lang#43482), as well. This allowed it to only be built after stage1, when proc-macros would be available, allowing the "rendering differences" PR to finally land. * The warnings were not perfect, and revealed a few [spurious](rust-lang#44368) [differences](rust-lang#45421) between how we handled the renderers. * Once these were handled, [we flipped the switch to turn on the "rendering difference" warnings all the time](rust-lang#45324), in October 2017. This began the "warning cycle" for this change, and landed in stable in 1.23, on 2018-01-04. * Once those warnings hit stable, and after a couple weeks of seeing whether we would get any more reports than what we got from sitting on nightly/beta, [we switched the renderers](rust-lang#47398), making Pulldown the default but still offering the option to use Hoedown. And that brings us to the present. We haven't received more new issues from this in the meantime, and the "switch by default" is now on beta. Our reasoning is that, at this point, anyone who would have been affected by this has run into it already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @GuillaumeGomez
r? @QuietMisdreavus