Fix example in transmute; add safety requirement to Vec::from_raw_parts #44536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
strega-nil
approved these changes
Sep 13, 2017
kennytm
reviewed
Sep 13, 2017
src/libcore/intrinsics.rs
Outdated
| /// // the original inner type (`&i32`) to the converted inner type | ||
| /// // (`Option<&i32>`), so read the nomicon pages linked above. | ||
| /// let v_from_raw = unsafe { | ||
| /// Vec::from_raw_parts(v_orig.as_mut_ptr(), | ||
| /// Vec::from_raw_parts(v_orig.as_mut_ptr() as *mut Option<&T>, |
There was a problem hiding this comment.
You mean as *mut Option<&i32> here?
[01:05:15] ---- intrinsics.rs - intrinsics::transmute (line 837) stdout ----
[01:05:15] error[E0412]: cannot find type `T` in this scope
[01:05:15] --> intrinsics.rs:29:61
[01:05:15] |
[01:05:15] 29 | Vec::from_raw_parts(v_orig.as_mut_ptr() as *mut Option<&T>,
[01:05:15] | ^ not found in this scope
Havvy
force-pushed
the
transmute-docs
branch
from
e069039 to
1d04254
Compare
Havvy
force-pushed
the
transmute-docs
branch
from
1d04254 to
9dd2ee1
Compare
|
@bors: r+ rollup thanks! |
|
📌 Commit 9dd2ee1 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 13, 2017
Fix example in transmute; add safety requirement to Vec::from_raw_parts This fixes the second bullet point on rust-lang#44281 and also removes some incorrect information.
aidanhs
added
the
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 14, 2017
Fix example in transmute; add safety requirement to Vec::from_raw_parts This fixes the second bullet point on rust-lang#44281 and also removes some incorrect information.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 15, 2017
Fix example in transmute; add safety requirement to Vec::from_raw_parts This fixes the second bullet point on rust-lang#44281 and also removes some incorrect information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the second bullet point on #44281 and also removes some incorrect information.