Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short doc examples for str::from_utf8_mut #44472

Merged
merged 5 commits into from
Sep 15, 2017
Merged

Conversation

smt923
Copy link
Contributor

@smt923 smt923 commented Sep 10, 2017

Fixes #44462

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Sep 10, 2017

📌 Commit 51bbd69 has been approved by alexcrichton

///
/// ```
/// use std::str;
///
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidy check failed. The source code should not contain trailing whitespaces.

[00:03:55] tidy error: /checkout/src/libcore/str/mod.rs:321: trailing whitespace
[00:03:55] tidy error: /checkout/src/libcore/str/mod.rs:326: trailing whitespace
[00:03:57] some tidy checks failed

@frewsxcv
Copy link
Member

@bors r+ rollup

thanks again!

@bors
Copy link
Contributor

bors commented Sep 10, 2017

📌 Commit 204414b has been approved by frewsxcv

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 11, 2017
Add short doc examples for str::from_utf8_mut

Fixes rust-lang#44462
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 11, 2017
Add short doc examples for str::from_utf8_mut

Fixes rust-lang#44462
@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 11, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 13, 2017
Add short doc examples for str::from_utf8_mut

Fixes rust-lang#44462
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 14, 2017
Add short doc examples for str::from_utf8_mut

Fixes rust-lang#44462
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 15, 2017
Add short doc examples for str::from_utf8_mut

Fixes rust-lang#44462
bors added a commit that referenced this pull request Sep 15, 2017
@bors bors merged commit 204414b into rust-lang:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants