Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"avoid" is a better word here than "disable" #44569

Merged
merged 1 commit into from
Sep 15, 2017
Merged

"avoid" is a better word here than "disable" #44569

merged 1 commit into from
Sep 15, 2017

Conversation

est31
Copy link
Member

@est31 est31 commented Sep 14, 2017

You don't "disable" the warning really, you just avoid it (as a conscious action).

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@est31
Copy link
Member Author

est31 commented Sep 14, 2017

r? @estebank

@rust-highfive rust-highfive assigned estebank and unassigned pnkfelix Sep 14, 2017
@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 14, 2017

📌 Commit 168f624 has been approved by estebank

@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 14, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 15, 2017
@frewsxcv
Rollup merge of rust-lang#44569 - est31:master, r=estebank
2a86884 
"avoid" is a better word here than "disable"

You don't "disable" the warning really, you just avoid it (as a conscious action).
@frewsxcv frewsxcv mentioned this pull request Sep 15, 2017
Merged
bors added a commit that referenced this pull request Sep 15, 2017
@bors
Auto merge of #44585 - frewsxcv:rollup, r=frewsxcv
d86a7f7 
Rollup of 23 pull requests

- Successful merges: #44131, #44254, #44368, #44374, #44378, #44388, #44430, #44450, #44453, #44472, #44476, #44477, #44485, #44497, #44521, #44534, #44536, #44541, #44552, #44559, #44563, #44569, #44572
- Failed merges:
@bors bors merged commit 168f624 into rust-lang:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@est31 @rust-highfive @estebank @bors @alexcrichton @pnkfelix